BIP 325: correct byte count for compact size #986

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:202009-bip325-1-5-bytes changing 1 files +2 −2

kallewoof commented at 7:33 AM on September 3, 2020: member

For 4-byte-push case, the push opcode was not counted; the length element is 1-5 bytes, not 4.

Also tweaks the 'signet header' name (removing 'scriptSig').
kallewoof cross-referenced this on Sep 3, 2020 from issue Slight cleanup of signet commitment description by instagibbs
bip-0325: correct byte count for compact size, and tweak to header name 8aaefbe8ea

in bip-0325.mediawiki:32 in 367f115fb2 outdated

  27 | @@ -28,7 +28,7 @@ A new type of network ("signet"), which takes an additional consensus parameter
  28 |  
  29 |  The witness commitment of the coinbase transaction is extended to include a secondary commitment (the signature/solution) of either:
  30 |  
  31 | -    1-4 bytes - Push the following (4 + x + y) bytes
  32 | +    1-5 bytes - Push the following (4 + x + y) bytes
  33 |      4 bytes - Signet scriptSig header (0xecc7daa2)

MarcoFalke commented at 7:45 AM on September 3, 2020:

    4 bytes - Signet header (0xecc7daa2)

Could fixup this one as well when touching the adjacent line?

kallewoof commented at 7:54 AM on September 3, 2020:

Done!

kallewoof force-pushed on Sep 3, 2020
MarcoFalke commented at 8:06 AM on September 3, 2020: member

ACK 8aaefbe8ea08e2fa0153d17b0348b60b8f4a6bd5
ajtowns commented at 8:31 AM on September 3, 2020: contributor

ACK
kallewoof commented at 10:24 AM on September 3, 2020: member

Merge at your convenience, @luke-jr.
luke-jr merged this on Sep 8, 2020
luke-jr closed this on Sep 8, 2020

Contributors

kallewoof

MarcoFalke

ajtowns

Linked (view graph)

#976 Slight cleanup of signet commitment description