[init] Deduplicated sigaction() boilerplate #10057

pull tjps wants to merge 1 commits into bitcoin:master from tjps:tjps_dedupe_sigaction changing 1 files +19 −14

tjps commented at 8:31 PM on March 22, 2017: contributor

No description provided.
fanquake added the label Refactoring on Mar 22, 2017
fanquake renamed this:
~~[trivial] Deduplicated sigaction() boilerplate~~
[init] Deduplicated sigaction() boilerplate
on Mar 22, 2017
paveljanik commented at 7:16 AM on March 23, 2017: contributor

utACK https://github.com/bitcoin/bitcoin/pull/10057/commits/f21bddeaad8b88a30ed02e99ac76fde816c5954f

Thanks for extending comment about the usage of atomic variables.
laanwj commented at 12:48 PM on March 24, 2017: member

Makes sense. utACK https://github.com/bitcoin/bitcoin/pull/10057/commits/f21bddeaad8b88a30ed02e99ac76fde816c5954f

Please remove "trivial" from the commit message and ~PR title~ though. Trivial means that there are effectively no code changes, only comment or variable name changes. This is explained in CONTRIBUTING.md.
Deduplicated sigaction() boilerplate 81a3857c4e
tjps commented at 5:35 PM on March 24, 2017: contributor

Updated the commit message. Just to be clear, after having read CONTRIBUTING.md, should I include the area [prefix] in just the PR title, or the commit message as well?
sipa commented at 8:36 PM on March 24, 2017: member

utACK
laanwj commented at 8:36 AM on March 27, 2017: member

Updated the commit message. Just to be clear, after having read CONTRIBUTING.md, should I include the area [prefix] in just the PR title, or the commit message as well?

Yes, the doc is unclear about that but in principle formatting for the PR title is the same as the commit message. The only difference is that the PR title summarizes a group of commits instead of one commit. If there is only one commit then they can (and should usually) be the same.
laanwj merged this on Mar 27, 2017
laanwj closed this on Mar 27, 2017
laanwj referenced this in commit 5114f81136 on Mar 27, 2017
tjps deleted the branch on May 1, 2017
PastaPastaPasta referenced this in commit aef6ec0138 on Mar 14, 2019
PastaPastaPasta referenced this in commit f305d4ad67 on May 20, 2019
PastaPastaPasta referenced this in commit c2258978bf on May 21, 2019
PastaPastaPasta referenced this in commit 35ee3bf8ab on May 21, 2019
barrystyle referenced this in commit 387992933a on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels