[rpc] Createrawtransaction doc does not match named args #10079

issue MarcoFalke openend this issue on March 25, 2017
  1. MarcoFalke commented at 4:25 pm on March 25, 2017: member

    According to the help text of createrawtransaction, the following args are accepted:

    0Arguments:
    11. "inputs"                (string, required) A json array of json objects
    22. "outputs"               (string, required) a json object with outputs
    33. locktime                  (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs
    

    however, this does not match the named args ( https://github.com/bitcoin/bitcoin/blob/8152d3fe57a991e9088d0b9d261d2b10936f45a9/src/rpc/client.cpp#L84 )

    Imo, backporting a breaking change to 0.14.1 is reasonable. Though, I’d like to hear other opinions.

  2. MarcoFalke added the label RPC/REST/ZMQ on Mar 25, 2017
  3. jnewbery commented at 0:08 am on March 26, 2017: member
    Named arguments were only introduced in 0.14.0, so I think it makes sense to change this and backport to 0.14.0.
  4. laanwj closed this on Mar 29, 2017

  5. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me