Docs: remove ’noconnect’ option #10085

pull jlopp wants to merge 1 commits into bitcoin:master from jlopp:noconnect changing 1 files +3 −3
  1. jlopp commented at 1:16 pm on March 26, 2017: contributor
    As far as I can tell, “noconnect” is never actually parsed as an argument in the codebase.
  2. remove 'noconnect' option from documentation d5690f1ab8
  3. fanquake added the label Docs and Output on Mar 26, 2017
  4. luke-jr commented at 5:30 pm on March 26, 2017: member
    -no* is the same as -*=0
  5. jlopp commented at 5:38 pm on March 26, 2017: contributor
    @luke-jr can you point out where the logic is that translates a “no*” parameter into a “*=0” parameter?
  6. MarcoFalke commented at 6:20 pm on March 26, 2017: member

    https://github.com/bitcoin/bitcoin/blob/111849345bb5140f86b48e730ceab4bff45fa2e9/src/util.cpp#L339

    On Sun, Mar 26, 2017 at 7:38 PM, Jameson Lopp notifications@github.com wrote:

    @luke-jr https://github.com/luke-jr can you point out where the logic is that translates a “no*” parameter into a “*=0” parameter?

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10085#issuecomment-289301163, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmvzH6lDVKoYxIbrA6xW3hdV-B9Chdks5rpqKNgaJpZM4MpbHR .

  7. jlopp commented at 7:42 pm on March 26, 2017: contributor
    Aha; thanks for the clarification.
  8. jlopp closed this on Mar 26, 2017

  9. sipa commented at 7:43 pm on March 26, 2017: member
    @jlopp If it wasn’t clear that -noX is an alias for -X=0, perhaps that should be documented more clearly in the -help output?
  10. MarcoFalke commented at 7:46 pm on March 26, 2017: member

    utACK d5690f1ab87678278d622ea82f3fa569314a2144. I think this makes it easier to understand.

    On Sun, Mar 26, 2017 at 9:43 PM, Jameson Lopp notifications@github.com wrote:

    Closed #10085.

    — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

  11. jlopp commented at 7:47 pm on March 26, 2017: contributor
    @sipa Yes, possibly - I’ll think about it. I’m currently working on a project involving Bitcoin Core’s configuration options, which is why I’m currently exploring this area of the codebase.
  12. sipa commented at 9:20 pm on March 26, 2017: member
    @jlopp, regardless, I agree with @MarcoFalke that this PR probably improves things, despite not fixing anything technically incorrect. I suggest reopening.
  13. jlopp commented at 9:28 pm on March 26, 2017: contributor
    Sure, done.
  14. jlopp reopened this on Mar 26, 2017

  15. laanwj commented at 7:01 am on March 27, 2017: member
    -noconnect works fine and I use it a lot for internal tests. It’s a little bit more consistent to not mention it explicitly in the help I guess but please don’t say that things don’t work if they do!
  16. laanwj merged this on Mar 27, 2017
  17. laanwj closed this on Mar 27, 2017

  18. laanwj referenced this in commit db1ae5470b on Mar 27, 2017
  19. PastaPastaPasta referenced this in commit 421c6800a7 on Mar 14, 2019
  20. PastaPastaPasta referenced this in commit efd11b29ef on May 20, 2019
  21. PastaPastaPasta referenced this in commit 14001a3d94 on May 21, 2019
  22. PastaPastaPasta referenced this in commit 16ad3219fb on May 21, 2019
  23. barrystyle referenced this in commit 964168761d on Jan 22, 2020
  24. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me