Use transactions-updated as flush condition #1010

pull sipa wants to merge 1 commits into bitcoin:master from sipa:fastblocks2 changing 1 files +12 −2
  1. sipa commented at 7:01 PM on March 29, 2012: member

    The normal checkpointing during the block chain download is reduced to every five minutes only, but forced every 200000 updated transactions.

  2. Use transactions-updated as flush condition
    The normal checkpointing during the block chain download is reduced
to every five minutes only, but forced every 200000 updated transactions.
    25c5eca893
  3. sipa commented at 7:02 PM on March 29, 2012: member

    With this patch I did my fastest full block chain load from a local file yet, and did so with never needing more than 120 MiB of log files. After #1007 (which does not appear slower), this still requires 220 MiB.

  4. gavinandresen commented at 7:06 PM on March 29, 2012: contributor

    ACK

  5. gavinandresen referenced this in commit f146061d24 on Mar 29, 2012
  6. gavinandresen merged this on Mar 29, 2012
  7. gavinandresen closed this on Mar 29, 2012
  8. jgarzik commented at 8:38 PM on March 29, 2012: contributor

    Not sure I see the value of the 200,000 hueristic.

  9. sipa commented at 11:48 PM on March 29, 2012: member

    @jgarzik it was chosen after some benchmarks that counted the number of transactions between flushes. Flushing every 200000 transactions causes max 120 MiB log files, which seemed reasonable as long as it did not decrease block sync efficiency.

  10. jgarzik commented at 1:22 AM on March 30, 2012: contributor

    Just the simple time-based heuristic would seem to suffice for both initial block download and thereafter. maintaining the 200k counter seems rather useless after I.B.D. completion.

    But no big matter... just a nit, not a NAK :)

  11. coblee referenced this in commit 874fadfbea on Jul 17, 2012
  12. ghostlander referenced this in commit 0d89e5509e on Dec 10, 2014
  13. suprnurd referenced this in commit e61b783e0e on Dec 5, 2017
  14. ptschip referenced this in commit 13bcaafe2f on Apr 4, 2018
  15. Bushstar referenced this in commit 6c44426d68 on Oct 14, 2019
  16. lateminer referenced this in commit 6ff12f70de on Oct 30, 2019
  17. DrahtBot locked this on Sep 8, 2021
Contributors
sipagavinandresenjgarzik
Linked (view graph)
#1012 bitcoin-qt slow to shut down after recent commits#1045 Flush on log size instead of transaction count
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me