[WIP] Remove NetworkThread from individual test cases #10111

pull jnewbery wants to merge 3 commits into bitcoin:master from jnewbery:remove_network_thread_from_test_scripts changing 24 files +49 −138
  1. jnewbery commented at 8:01 PM on March 28, 2017: member

    This commit starts the NetworkThread automatically in the test framework, which means that the individual test cases don't need to start the thread after they've added the p2p connections.

    It also updates the NodeConnCB.add_connection() method to wait for verack by default. This means the test writer only needs to call add_connection() in order to have a p2p connection ready for use.

    This builds on #10109 . Only the 'Remove NetworkThread from individual test cases' commit needs to be reviewed

    As discussed @sdaftuar - should be another easy review.

  2. fanquake added the label Tests on Mar 29, 2017
  3. fanquake added the label Refactoring on Mar 29, 2017
  4. jnewbery force-pushed on Mar 30, 2017
  5. jnewbery force-pushed on Mar 30, 2017
  6. jnewbery force-pushed on Apr 5, 2017
  7. Remove network thread from test scripts 51567290d7
  8. fixup acc2075407
  9. fixup: sync-ping on connect
    to make sure that our verack has been processed
    d543b533e8
  10. jnewbery force-pushed on Apr 5, 2017
  11. jnewbery renamed this:
    Remove NetworkThread from individual test cases
    [WIP] Remove NetworkThread from individual test cases
    on Apr 5, 2017
  12. jnewbery commented at 2:14 AM on April 8, 2017: member

    Closing this for now. I still think this is the right way to go, but I need to sequence the commits differently. NodeConn and NodeConnCB need to be initialized differently to avoid the timing issues that are happening on Travis.

  13. jnewbery closed this on Apr 8, 2017

  14. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me