build: Disable Wshadow warning #10136

1. 
   laanwj commented at 12:21 pm on April 1, 2017: member

   This warning was enabled by default in #8808 but it’s a continuing source of annoyance for me and other developers. I’m sick of sounding like a broken record, so disable it again.
2. build: Disable Wshadow warning

   This warning was enabled by default in #8808 but it's a
   [continuing](https://github.com/bitcoin/bitcoin/pull/9911#issuecomment-285171447)
   [source](https://github.com/bitcoin/bitcoin/pull/10089#issuecomment-289369688) of
   [annoyance](https://github.com/bitcoin/bitcoin/pull/9911#issuecomment-285179129) for me
   and other developers. I'm sick of sounding like a broken record, so disable it again.

   2c83911401
3. laanwj added the label Build system on Apr 1, 2017
4. 
   jnewbery commented at 3:11 pm on April 1, 2017: member

   concept ACK (with apologies to @paveljanik!)

   If we can find a more intelligent way of managing these warnings so they’re not as annoying, I’m all for it. At the moment it feels like the Wshadow tail is wagging the dog.

5. 
   MarcoFalke commented at 3:31 pm on April 1, 2017: member

   utACK 2c83911

   This was clearly the wrong way to prevent variable name shadows.

6. 
   jonasschnelli commented at 3:47 pm on April 1, 2017: contributor

   utACK 2c839114010396b517dc5146065b133f578e7094
7. 
   laanwj commented at 6:27 am on April 2, 2017: member

   If we can find a more intelligent way of managing these warnings so they’re not as annoying, I’m all for it. At the moment it feels like the Wshadow tail is wagging the dog.

   This was clearly the wrong way to prevent variable name shadows.

   Agreed. And there is still value in compiling with Wshadow periodically (with a carefully chosen compiler) and seeing if it finds any bug.

8. laanwj merged this on Apr 2, 2017
9. laanwj closed this on Apr 2, 2017

   ---

10. laanwj referenced this in commit 81da4c7b5b on Apr 2, 2017
11. 
    paveljanik commented at 6:32 am on April 2, 2017: contributor

    Postmerge ACK. The real problem is that people use ancient compilers and I have not tested them all (only few selected by some distros as their default compilers).

    FWIW: I’ll compile all my builds with -Wshadow to catch all new occurrences. And of course, thanks for patience :-)

12. PastaPastaPasta referenced this in commit 137e8604ad on May 10, 2019
13. PastaPastaPasta referenced this in commit 7d6f8eda1b on May 15, 2019
14. PastaPastaPasta referenced this in commit 07ed44df6b on May 20, 2019
15. PastaPastaPasta referenced this in commit 12989cfe8e on May 21, 2019
16. barrystyle referenced this in commit cdb5dc270f on Jan 22, 2020
17. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj jnewbery MarcoFalke jonasschnelli paveljanik

Labels
Build system