Fixed compiler warning / hint "commas at the end of enumerator lists are a C++0x-specific feature". Guess the commas were there by mistake, so I removed them and it still compiles fine :).
fix "commas at the end of enumerator lists..." compiler warning #1014
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:fix-enums changing 6 files +7 −7-
Diapolo commented at 12:25 PM on March 30, 2012: none
-
fix "commas at the end of enumerator lists..." compiler warning c337df07c3
-
sipa commented at 1:49 PM on March 31, 2012: member
Keeping the comma's there makes patches that add new enum entries smaller and less conflicting. Is this actually a problem on any supported platform?
-
Diapolo commented at 2:01 PM on March 31, 2012: none
It's "ugly" and unsupported, if the used compiler is not C++0x compatible. There should be coding standards for this, as everyone seems to handle this differently all over the source, which is bad practise IMHO.
-
laanwj commented at 7:10 AM on April 2, 2012: member
I think sipa's patch-cleanlyness argument is pretty convincing. I see this as "in the future it will be allowed, so why bother fixing it".
No compiler that I know of has problems with this (g++, clang, VC). And I suppose we will switch to c++0x when the time is right.
If you like to clean up compiler warnings, there are more pressing ones to fix. For example, questionable type conversions and potentially dangerous signed/unsigned comparisons.
-
Diapolo commented at 7:53 AM on April 2, 2012: none
Alright, but please let's do something about coding standards in general. There are some rules defined in the docs, but there are large parts of the code not using that.
- Diapolo closed this on Apr 2, 2012
- ptschip referenced this in commit 8ebbf4d71d on Apr 5, 2018
- lateminer referenced this in commit 49f42e9a59 on Oct 30, 2019
- lateminer referenced this in commit 8043af4b18 on Nov 14, 2019
- lateminer referenced this in commit 645854ad57 on Nov 14, 2019
- DrahtBot locked this on Sep 8, 2021
