Currently test_runner reports an error if a test case is skipped. This is not how it should be, only failed tests should cause it to fail. (hopefully this fixes travis)
tests: Fix test_runner return value in case of skipped test #10187
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2017_04_fix_tracis changing 1 files +6 −2-
laanwj commented at 5:52 PM on April 11, 2017: member
-
e96462fbec
tests: Fix test_runner return value in case of skipped test
Currently test_runner reports an error if a test case is skipped. This is not how it should be, only failed tests should cause it to fail.
- laanwj added the label Tests on Apr 11, 2017
-
MarcoFalke commented at 8:29 PM on April 11, 2017: member
Thanks! utACK e96462fbece87448619ba23f4917de2bfc257ee6.
On Tue, Apr 11, 2017 at 7:53 PM, Wladimir J. van der Laan notifications@github.com wrote:
Currently test_runner reports an error if a test case is skipped. This is not how it should be, only failed tests should cause it to fail.
You can view, comment on, or merge this pull request online at:
Commit Summary
tests: Fix test_runner return value in case of skipped test
File Changes
M test/functional/test_runner.py (8)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
-
jnewbery commented at 9:01 PM on April 11, 2017: member
tested ACK e96462fbece87448619ba23f4917de2bfc257ee6
nit:
was_successfulis a misnomer. Perhapsdid_not_failis better? -
MarcoFalke commented at 10:58 PM on April 11, 2017: member
Going to merge now to fix travis. We can figure out the naming issue the next time this file is touched.
- MarcoFalke merged this on Apr 11, 2017
- MarcoFalke closed this on Apr 11, 2017
- MarcoFalke referenced this in commit b44adf9234 on Apr 11, 2017
-
laanwj commented at 9:18 AM on April 12, 2017: member
nit: was_successful is a misnomer. Perhaps did_not_fail is better?
I considered that but found it too literal. There may be more statuses in the future, some considered a failure some successful. Note that I didn't use "has_passed" either.
-
jtimon commented at 4:22 PM on April 18, 2017: contributor
post-merge utACK e96462fbece87448619ba23f4917de2bfc257ee6
- PastaPastaPasta referenced this in commit c011c578e0 on Jun 10, 2019
- PastaPastaPasta referenced this in commit 656f155714 on Jun 11, 2019
- PastaPastaPasta referenced this in commit a18585bdea on Jun 15, 2019
- PastaPastaPasta referenced this in commit 44fb3477f9 on Jun 19, 2019
- PastaPastaPasta referenced this in commit 23bf5ea7b1 on Jun 19, 2019
- PastaPastaPasta referenced this in commit 38e809a678 on Jun 19, 2019
- PastaPastaPasta referenced this in commit e74eded44a on Jun 19, 2019
- PastaPastaPasta referenced this in commit 21b0da71bf on Jun 19, 2019
- PastaPastaPasta referenced this in commit 6b9e864a08 on Jun 19, 2019
- PastaPastaPasta referenced this in commit d84c62b2c8 on Jun 19, 2019
- PastaPastaPasta referenced this in commit 8006bb5c25 on Jun 20, 2019
- codablock referenced this in commit 79e221aebe on Jun 21, 2019
- barrystyle referenced this in commit 9c7f7c5164 on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels