[Wallet] FundRawTransaction can accept pre-set inputs whose parent is not yet broadcasted #10216

pull NicolasDorier wants to merge 7 commits into bitcoin:master from NicolasDorier:fundrawtransaction2 changing 6 files +236 −33

NicolasDorier commented at 4:40 AM on April 15, 2017: contributor

This PR is based on #10202, it allows the user to pre fund a transaction with inputs which have not yet been broadcasted. Please, review and ACK the first one independently from this PR.

This is useful for second layer payment protocol which regularly build transaction on top of unbroadcasted transaction.
[Wallet] Pass CCoinControl as parameter of CWallet::FundTransaction 2ad20a96df
[Wallet] Fetch CInputCoins from CWallet before calling FundTransaction 2f2e25ddc0
[Wallet] Fetch CInputCoins from CCoinView before calling FundTransaction 0855c46e58
[Wallet] FundRawTransaction returns unknown-input error on invalid input 8fd0b6a0c9
[Wallet] Test FundRawTransaction with inputs from the CoinView 8950e8afd6
[Wallet] FundRawTransaction can accept pre-set inputs whose parent is not yet broadcasted caea518e44
[Wallet] Test FundRawTransaction with input from a non existing transaction 8b1c4a3ae1
fanquake added the label RPC/REST/ZMQ on Apr 15, 2017
fanquake added the label Wallet on Apr 15, 2017
jonasschnelli commented at 7:42 PM on August 15, 2017: contributor

Needs rebase.
NicolasDorier commented at 5:13 PM on March 6, 2018: contributor

I workedaround this need for this.
NicolasDorier closed this on Mar 6, 2018
JeremyRand commented at 4:24 AM on March 17, 2018: contributor

I workedaround this need for this. @NicolasDorier may I ask what your workaround was? I was very much hoping to see this PR merged, I'd love to see a workaround.
NicolasDorier commented at 7:43 AM on March 18, 2018: contributor

@JeremyRand I just gave up using the RPC for my projects, getting things merged here is a bit too much effort, it was easier for me to create NBXplorer which is a lightweight block explorer for bitcoin also working on pruned mode.

Feel free to rebase and take this PR if you feel the strength to get it merged, I would review.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10202 [Wallet] FundRawTransaction can fund a transaction with preset inputs found in the CoinView