[scripts] Minor improvements to `macdeployqtplus` script. #10273

pull chrisgavin wants to merge 2 commits into bitcoin:master from chrisgavin:macdeployqtplus changing 1 files +2 −4
  1. chrisgavin commented at 8:18 AM on April 25, 2017: contributor

    No description provided.

  2. Remove unused variable from `macdeployqtplus` script. 4f3ac7ddd7
  3. Use `with` in `macdeployqtplus` script. e8babc4330
  4. laanwj added the label Build system on Apr 25, 2017
  5. in contrib/macdeploy/macdeployqtplus:305 in e8babc4330 
     301 | @@ -302,7 +302,6 @@ def copyFramework(framework, path, verbose):
 302 |          if os.path.exists(fromContentsDir):
 303 |              toContentsDir = os.path.join(path, framework.destinationVersionContentsDirectory)
 304 |              shutil.copytree(fromContentsDir, toContentsDir, symlinks=True)
 305 | -            contentslinkfrom = os.path.join(path, framework.destinationContentsDirectory)
    jonasschnelli commented at 7:40 PM on April 25, 2017:

    What's the reason to remove this line? We don't use dynamic linked custom Frameworks in the Bitcoin-Qt.app bundle.

    chrisgavin commented at 9:24 PM on April 25, 2017:

    In af0bd5e, the majority of this code was removed but I think this line was left in by mistake. As far as I can tell it doesn't do anything - it just defines a variable that is never used.

  6. jonasschnelli added the label MacOSX on Apr 25, 2017
  7. jonasschnelli commented at 6:57 AM on April 26, 2017: contributor

    Yes. Makes sense (though a very tiny optimisation/cleanup near PR "dust-limit"). utACK e8babc4330cd7db82650f28147c388846a389c77

  8. jonasschnelli commented at 7:33 AM on April 26, 2017: contributor

    Builds the DMG correctly (https://bitcoin.jonasschnelli.ch/build/113). Tested ACK e8babc4330cd7db82650f28147c388846a389c77

  9. laanwj merged this on Apr 26, 2017
  10. laanwj closed this on Apr 26, 2017
  11. laanwj referenced this in commit 8979f4569e on Apr 26, 2017
  12. PastaPastaPasta referenced this in commit 688d6e98b3 on May 10, 2019
  13. PastaPastaPasta referenced this in commit 332b995cec on May 15, 2019
  14. PastaPastaPasta referenced this in commit 0d2f2b3617 on May 20, 2019
  15. PastaPastaPasta referenced this in commit 91b39f3b73 on May 21, 2019
  16. barrystyle referenced this in commit 8a02eff321 on Jan 22, 2020
  17. jasonbcox referenced this in commit 2f142e5a3a on Oct 17, 2020
  18. MarcoFalke locked this on Sep 8, 2021
Contributors
chrisgavinjonasschnelli
Labels
macOSBuild system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me