contrib/verifybinaries: allow filtering by platform #10276

pull knocte wants to merge 1 commits into bitcoin:master from knocte:filterByPlatformInVerifySh changing 2 files +46 −5
  1. knocte commented at 11:03 AM on April 25, 2017: contributor

    Downloading all the binaries of all platforms can take quite long, especially for slow connections, which may deter people from using this script and, therefore, to disregard security altogether.

    This change introduces the new possibility of specifying the platform along with the version number, so that only the binaries that contain the platform name are downloaded.

  2. knocte force-pushed on Apr 25, 2017
  3. knocte force-pushed on Apr 25, 2017
  4. fanquake added the label Scripts and tools on Apr 25, 2017
  5. laanwj commented at 3:56 PM on April 25, 2017: member

    Concept ACK, seems useful.

  6. jonasschnelli commented at 7:33 PM on April 25, 2017: contributor

    Concept ACK

  7. laanwj commented at 2:56 PM on June 5, 2017: member

    Just tested this. Found one issue: looks like the script hangs indefinitely when providing an argument that doesn't match any files. E.g.

    ./verify.sh 0.12.0-linx
    
  8. knocte commented at 3:47 PM on June 5, 2017: contributor

    I'll fix it, thanks for the feedback.

  9. contrib/verifybinaries: allow filtering by platform
    Downloading all the binaries of all platforms can take quite long,
    especially for slow connections, which may deter people from using
    this script and, therefore, to disregard security altogether.
    
    This change introduces the new possibility of specifying the
    platform along with the version number, so that only the binaries
    that contain the platform name are downloaded.
    8d4dafd774
  10. knocte force-pushed on Jun 6, 2017
  11. knocte commented at 6:56 AM on June 6, 2017: contributor

    Updated: if a platform name is provided that doesn't match any files, it will fail now with an error instead of hanging.

    NB: I don't know why the windows travis-CI build failed, looks unrelated to this...

  12. MarcoFalke commented at 11:22 AM on June 6, 2017: member

    ACK 8d4dafd774436a355b6aa49a44b867cf78c38f6d

  13. laanwj merged this on Jun 22, 2017
  14. laanwj closed this on Jun 22, 2017

  15. laanwj referenced this in commit b750b33c3c on Jun 22, 2017
  16. laanwj commented at 5:34 PM on June 22, 2017: member

    ACK 8d4dafd

  17. PastaPastaPasta referenced this in commit 66e2c6c6b6 on Jul 6, 2019
  18. PastaPastaPasta referenced this in commit d6b8068aa0 on Jul 8, 2019
  19. PastaPastaPasta referenced this in commit e7def21647 on Jul 9, 2019
  20. PastaPastaPasta referenced this in commit 2116e93019 on Jul 11, 2019
  21. barrystyle referenced this in commit 264c06a9b5 on Jan 22, 2020
  22. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me