[test] Unit test amount.h/amount.cpp #10280

pull jimmysong wants to merge 1 commits into bitcoin:master from jimmysong:test_amount changing 1 files +37 −1

jimmysong commented at 4:05 AM on April 26, 2017: contributor

Add tests for MoneyRange, binary operators, ToString and a constructor
fanquake added the label Tests on Apr 26, 2017

in src/test/amount_tests.cpp:95 in d8a405bd94 outdated

  90 | +    BOOST_CHECK(a == a);
  91 | +    BOOST_CHECK(a <= b);
  92 | +    BOOST_CHECK(a <= a);
  93 | +    BOOST_CHECK(b >= a);
  94 | +    BOOST_CHECK(b >= b);
  95 | +    // a should now have 2 satoshis/kb

paveljanik commented at 6:40 AM on April 26, 2017:

super-micro-nit: let's use our ToString() form here:

// a should be 0.00000002 BTC/kB now

paveljanik commented at 6:41 AM on April 26, 2017: contributor

Brilliant! Please fix my super-micro-nit and ACK
jonasschnelli commented at 6:44 AM on April 26, 2017: contributor

utACK d8a405bd94f0f609602bf55c80cf09f4d57d7d3c
laanwj commented at 10:18 AM on April 26, 2017: member

utACK

[test] Unit test amount.h/amount.cpp

Add tests for MoneyRange, binary operators, ToString and a constructor

dcb69fde5a

jimmysong force-pushed on Apr 26, 2017
jimmysong commented at 2:26 PM on April 26, 2017: contributor

nit addressed and squashed.
paveljanik commented at 7:11 PM on April 26, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/10280/commits/dcb69fde5aae3ef572e299e57a45712f005daf8b

247 -> 250 tests. Thank you!
MarcoFalke merged this on Apr 26, 2017
MarcoFalke closed this on Apr 26, 2017
MarcoFalke referenced this in commit 47535d7c3e on Apr 26, 2017
jasonbcox referenced this in commit a9cd88bfcd on May 15, 2019
PastaPastaPasta referenced this in commit 5d6b032ce3 on Jun 10, 2019
PastaPastaPasta referenced this in commit 31ce813013 on Jun 10, 2019
PastaPastaPasta referenced this in commit a2d231416c on Jun 10, 2019
PastaPastaPasta referenced this in commit 1d17e9da26 on Jun 11, 2019
PastaPastaPasta referenced this in commit 832415f7b5 on Jun 11, 2019
PastaPastaPasta referenced this in commit 31cf95ea8d on Jun 12, 2019
jonspock referenced this in commit e062b3b409 on Jun 13, 2019
jonspock referenced this in commit 060ea21737 on Jun 13, 2019
PastaPastaPasta referenced this in commit 49bfb285c0 on Jun 14, 2019
PastaPastaPasta referenced this in commit 24bf903eff on Jun 14, 2019
PastaPastaPasta referenced this in commit 94c79e8691 on Jun 14, 2019
PastaPastaPasta referenced this in commit b1b7885ace on Jun 15, 2019
PastaPastaPasta referenced this in commit 605ea0cc3a on Jun 19, 2019
PastaPastaPasta referenced this in commit aaab6f6be9 on Jun 19, 2019
PastaPastaPasta referenced this in commit 238c1d73af on Jun 19, 2019
PastaPastaPasta referenced this in commit 38803e0986 on Jun 19, 2019
PastaPastaPasta referenced this in commit 18638a6c3b on Jun 19, 2019
PastaPastaPasta referenced this in commit 049086e3a1 on Jun 19, 2019
PastaPastaPasta referenced this in commit 2e39510a18 on Jun 19, 2019
PastaPastaPasta referenced this in commit 26178817d2 on Jun 20, 2019
PastaPastaPasta referenced this in commit 6d5d128c65 on Jun 22, 2019
PastaPastaPasta referenced this in commit 5bff69c5c3 on Jun 22, 2019
PastaPastaPasta referenced this in commit 677f9bc3ca on Jun 22, 2019
PastaPastaPasta referenced this in commit 7bfdc3567a on Jun 22, 2019
barrystyle referenced this in commit e1f15b7877 on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels