[bench] Include ms/blk stats in Connect* benchmarks. #10303

pull kallewoof wants to merge 2 commits into bitcoin:master from kallewoof:bench-add-per-block-stats changing 1 files +20 −14
  1. kallewoof commented at 4:57 AM on May 1, 2017: member

    Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics.

  2. fanquake added the label Tests on May 1, 2017
  3. MarcoFalke added the label Docs and Output on May 1, 2017
  4. sipa commented at 10:43 PM on May 1, 2017: member

    Concept ACK

  5. kallewoof commented at 1:01 AM on May 2, 2017: member

    After some days of running, this is what it looks like:

    2017-05-02 00:50:09 - Connect block: 69.00ms [61.34s (107.42ms/blk)]
2017-05-02 00:54:03   - Load block from disk: 0.00ms [0.03s]
2017-05-02 00:54:03     - Sanity checks: 0.00ms [0.00s (0.01ms/blk)]
2017-05-02 00:54:03     - Fork checks: 0.03ms [0.02s (0.03ms/blk)]
2017-05-02 00:54:03       - Connect 1942 transactions: 30.89ms (0.016ms/tx, 0.008ms/txin) [35.05s (61.28ms/blk)]
2017-05-02 00:54:03     - Verify 3960 txins: 48.62ms (0.012ms/txin) [45.90s (80.25ms/blk)]
2017-05-02 00:54:03     - Index writing: 2.74ms [1.71s (3.00ms/blk)]
2017-05-02 00:54:03     - Callbacks: 0.02ms [0.01s (0.02ms/blk)]
2017-05-02 00:54:03   - Connect total: 51.58ms [47.76s (83.49ms/blk)]
2017-05-02 00:54:03   - Flush: 5.78ms [3.19s (5.58ms/blk)]
2017-05-02 00:54:03   - Writing chainstate: 0.03ms [0.05s (0.10ms/blk)]
2017-05-02 00:54:03 UpdateTip: new best=000000000000000001f02798776e208f8de551a0a5ddab0b6ed4b44665a04140 height=464424 version=0x30000000 log2_work=86.366385 tx=218199087 date='2017-05-02 00:53:59' progress=1.000000 cache=190.9MiB(156242tx) warning='1 of last 100 blocks have unexpected version'
2017-05-02 00:54:03   - Connect postprocess: 15.89ms [10.38s (18.15ms/blk)]
2017-05-02 00:54:03 - Connect block: 73.27ms [61.41s (107.36ms/blk)]
  6. jonasschnelli commented at 6:50 AM on May 2, 2017: contributor

    utACK 1d0cdc07c4db1e0d0df7a55696543165506de09f

  8. [bench] Include ms/blk stats in Connect* benchmarks. 5f850b0311
  9. [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. a473eff8f9
  10. in src/validation.cpp:1745 in 1d0cdc07c4 outdated 
    1741 | @@ -1739,7 +1742,7 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd
1742 |      }
1743 |  
1744 |      int64_t nTime1 = GetTimeMicros(); nTimeCheck += nTime1 - nTimeStart;
1745 | -    LogPrint(BCLog::BENCH, "    - Sanity checks: %.2fms [%.2fs]\n", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001);
1746 | +    LogPrint(BCLog::BENCH, "    - Sanity checks: %.2fms [%.2fs (%.2fms/blk)]\n", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001, nTimeCheck * 0.001 / nBlocksTotal);
    jtimon commented at 4:54 PM on May 31, 2017:

    Perhaps 0.001 can be a constant? maybe 0.000001 too ?

    kallewoof commented at 2:43 AM on June 1, 2017:

    Makes sense, I think.

  11. kallewoof force-pushed on Jun 1, 2017
  12. laanwj merged this on Aug 28, 2017
  13. laanwj closed this on Aug 28, 2017
  14. laanwj referenced this in commit f088a1bb39 on Aug 28, 2017
  15. PastaPastaPasta referenced this in commit 60b6598028 on Sep 19, 2019
  16. PastaPastaPasta referenced this in commit 39663bcd4b on Sep 23, 2019
  17. PastaPastaPasta referenced this in commit 5954be177d on Sep 24, 2019
  18. kallewoof deleted the branch on Oct 17, 2019
  19. PastaPastaPasta referenced this in commit 916bd4624d on Nov 19, 2019
  20. PastaPastaPasta referenced this in commit ed130e821f on Nov 21, 2019
  21. PastaPastaPasta referenced this in commit a5525459c0 on Dec 9, 2019
  22. PastaPastaPasta referenced this in commit abbe5df4cc on Jan 1, 2020
  23. PastaPastaPasta referenced this in commit d4730fe07a on Jan 2, 2020
  24. PastaPastaPasta referenced this in commit dd7486932e on Jan 2, 2020
  25. PastaPastaPasta referenced this in commit 60f603b833 on Jan 2, 2020
  26. PastaPastaPasta referenced this in commit f9afccbcfe on Jan 2, 2020
  27. PastaPastaPasta referenced this in commit 060e7c043e on Jan 2, 2020
  28. PastaPastaPasta referenced this in commit 73c57aa78a on Jan 2, 2020
  29. PastaPastaPasta referenced this in commit c3de636c70 on Jan 2, 2020
  30. PastaPastaPasta referenced this in commit 742d6e99fa on Jan 3, 2020
  31. PastaPastaPasta referenced this in commit da55a85858 on Jan 10, 2020
  32. ckti referenced this in commit 56517f7664 on Mar 28, 2021
  33. DrahtBot locked this on Dec 16, 2021
Contributors
kallewoofsipajonasschnellipaveljanikjtimon
Labels
DocsTests
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me