See #10300.
[rpc] Allow a txid param in getrawmempool #10304
pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:getrawmempool-include-txid changing 2 files +26 −14-
kallewoof commented at 10:05 AM on May 1, 2017: member
-
[rpc] Allow a txid param in getrawmempool to get details about specific transaction if found. Closes #10300 0300d5e556
- fanquake added the label RPC/REST/ZMQ on May 1, 2017
-
jnewbery commented at 9:35 PM on May 1, 2017: member
utACK 0300d5e556cc1556b9cba1ec11ff3eef47bddca5.
Can you add a test to exercise the new functionality? Perhaps add some calls to
getrawmempoolwith specified txids to the mempool_reorg test. Around here: https://github.com/bitcoin/bitcoin/blob/e2b99b13131b5d0fd6fae6d55892c2ebb327d438/test/functional/mempool_reorg.py#L88 -
sipa commented at 10:49 PM on May 1, 2017: member
I believe this functionality already exists as
getmempoolentry. -
kallewoof commented at 12:31 AM on May 2, 2017: member
@sipa Indeed, I had completely missed that one. I'm surprised there's a whole command for it, personally. (And it doesn't seem to be well known as several people (me, issue author, ..) did not realize it, so it may be an idea to mention it in getrawmempool help.)
- kallewoof closed this on May 2, 2017
-
paveljanik commented at 7:01 AM on May 4, 2017: contributor
Thinking a bit more about it,
gettransactionshould be generalised to include not only in-wallet transactions, but also in-mempool txs. as we have in-wallet, in-blockchain/non-wallet and in-mempool txs (why entries?). But this is backward incompatible change in the API. -
sipa commented at 7:58 AM on May 4, 2017: member
@paveljanik We have
getrawtransactionfor that, which can query for mempool transactions (and without-txindex, that's pretty much the only thing it is useful for).I disagree that
gettransactionshould be extended. Despite its name,gettransactionactually does not return information about a transaction, but is a wallet RPC that returns information about a ledger entry (i.e., the effects a transaction has on your personal balance). - kallewoof deleted the branch on May 9, 2017
- DrahtBot locked this on Sep 8, 2021