utACK 41bc5ba
TIL
Yes. Adding a hint makes sense.
Though I'm not sure if we should add it below the RPC/curl info. What speaks against mentioning getmempoolentry in the description?
agreed @jonasschnelli I think just putting that in the main body of help is best.
I might stop reading by the examples...
I agree with the others. The hint should be further up, between the main text and the arguments listing.
Otherwise utACK
Moved hint to below description. Should it be a part of it (i.e. no space)? Below is current output:
$ ./bitcoin-cli -regtest help getrawmempool
getrawmempool ( verbose )
Returns all transaction ids in memory pool as a json array of string transaction ids.
Hint: use getmempoolentry to fetch a specific transaction from the mempool.
Arguments:
1. verbose (boolean, optional, default=false) True for a json object, false for array of transaction ids
Result: (for verbose = false):
[ (json array of string)
"transactionid" (string) The transaction id
,...
]
Result: (for verbose = true):
{ (json object)
"transactionid" : { (json object)
[omitted]
}
Examples:
> bitcoin-cli getrawmempool true
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getrawmempool", "params": [true] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/
$
utACK
Apologies; re-committed verified, same as 06eb5a7.
utACK