Disconnecting a peer doesn't update the variables that affect p2p logic until FinalizeNode() is called, so it's helpful for debugging to have a log message in this function.
doc: Add logging to FinalizeNode() #10404
pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2017-05-log-finalize-node changing 1 files +1 −0-
sdaftuar commented at 2:22 PM on May 15, 2017: member
-
Add logging to FinalizeNode() 1530bfc72d
-
jnewbery commented at 5:14 PM on May 15, 2017: member
Tested ACK 1530bfc72d6e3a57cc81980faaf52d9b084353f2.
Minor suggestion:
Cleared nodestate for peeris a little cryptic without the context that the state is being cleared after disconnect. Perhaps better wording would be something like:Peer %d fully disconnected. NodeState cleared.Either way, this is useful logging, so ACK.
- MarcoFalke renamed this:
Add logging to FinalizeNode()
doc: Add logging to FinalizeNode()
on May 15, 2017 - MarcoFalke added the label Docs and Output on May 15, 2017
-
sipa commented at 10:31 PM on May 15, 2017: member
utACK 1530bfc72d6e3a57cc81980faaf52d9b084353f2
-
jonasschnelli commented at 6:48 AM on May 16, 2017: contributor
Seems useful. utACK 1530bfc72d6e3a57cc81980faaf52d9b084353f2
- laanwj merged this on May 17, 2017
- laanwj closed this on May 17, 2017
- laanwj referenced this in commit b45a52aeff on May 17, 2017
- PastaPastaPasta referenced this in commit 147f9081a1 on Jun 10, 2019
- PastaPastaPasta referenced this in commit a5f37a770d on Jun 11, 2019
- PastaPastaPasta referenced this in commit e76a7b3d10 on Jun 11, 2019
- PastaPastaPasta referenced this in commit 583001b66a on Jun 15, 2019
- PastaPastaPasta referenced this in commit 96718b4fe7 on Jun 19, 2019
- PastaPastaPasta referenced this in commit fc839f8dc3 on Jun 19, 2019
- PastaPastaPasta referenced this in commit c844bbb26a on Jun 19, 2019
- PastaPastaPasta referenced this in commit 35148e102c on Jun 19, 2019
- PastaPastaPasta referenced this in commit e550cbd3df on Jun 19, 2019
- PastaPastaPasta referenced this in commit 29415f2acf on Jun 20, 2019
- PastaPastaPasta referenced this in commit 9cfe49993c on Jun 22, 2019
- PastaPastaPasta referenced this in commit 7bdc0f11da on Jun 22, 2019
- PastaPastaPasta referenced this in commit d3f79e2945 on Jun 22, 2019
- PastaPastaPasta referenced this in commit 9dbbd5d031 on Jun 22, 2019
- PastaPastaPasta referenced this in commit 7b63e3618b on Jun 22, 2019
- PastaPastaPasta referenced this in commit c4bd31a4e4 on Jun 24, 2019
- barrystyle referenced this in commit d893e7886d on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels