If a test is skipped, it doesn't clean up its temp directory. This PR fixes that so skipped tests' temp directories are cleaned up after the test is skipped. The temp directory can be left intact by using the --nocleanup argument as usual.
Implementation: Define a SkipTest exception type. Catch it in the test_framework and go through the normal test teardown functionality. Similar to the SkipTest exception class in Python's standard unittest library @sdaftuar
Concept ACK
This runs fine on my local pc but something is causing the tests to hang on Travis. I've pushed a temporary commit to increase travis logging.
Concept ACK, though I'm also puzzled by the travis failures.
930deb9b2c5a8234d430f0a739c97e1fc961ffad passes travis (at least on my fork). I think the earlier failure was perhaps spurious.
This should now be ready for review.
ACK
utACK 930deb9b2c5a8234d430f0a739c97e1fc961ffad
154 | - success = True 155 | + success = TestStatus.PASSED 156 | except JSONRPCException as e: 157 | self.log.exception("JSONRPC error") 158 | + except SkipTest as e: 159 | + self.log.warning("Test Skipped: %s" % e.message)
This is info elsewhere, should it really be warning?
Yes - this log is replacing the logs in the individual test cases (rpcbind_test.py and zmq_test.py), which are currently warnings.
The reason is that we always want the user to know if a test has been skipped.
OK, I see. I thought the log.info below was also logging something similar. This is fine.
Tested ACK. 930deb9b2c5a8234d430f0a739c97e1fc961ffad