Improve commit-check-script.sh #10480

pull sipa wants to merge 1 commits into bitcoin:master from sipa:update_script_check changing 1 files +20 −13

sipa commented at 10:09 PM on May 30, 2017: member
This makes an improvement to commit-check-script.sh (which was introduced in #10189):
- Fail when a VERIFY SCRIPT is present in the commit body, but no scripted-diff exists in its title. This would have caught a bug in #10321 (which had script-diff instead of scripted-diff) by reducing the reviewer burden from noticing a correct scripted-diff to that or a correct VERIFY SCRIPT (using fairly fuzzy rules).
Fail on commit with VERIFY SCRIPT but no scripted-diff 5432fc3d59
jtimon commented at 10:43 PM on May 30, 2017: contributor

Concept ACK!
fanquake added the label Scripts and tools on May 30, 2017
theuni commented at 3:46 PM on May 31, 2017: member

utACK 5432fc3d59ce013d6c27f440ad86fc1f16d6e384. I don't believe the second commit is necessary, though. The diff is already shown regardless of success, this should make it print twice.
sipa force-pushed on Jun 3, 2017
sipa commented at 6:39 PM on June 3, 2017: member

@theuni Removed the last commit. I somehow assumed that what it was printing out was the whole commit, not just the unscripted diff...
laanwj merged this on Jun 13, 2017
laanwj closed this on Jun 13, 2017
laanwj referenced this in commit fbf5d3ba15 on Jun 13, 2017
jtimon commented at 8:37 PM on June 13, 2017: contributor

Perhaps it would be interesting to rebase #10502 just to check this (and #10502 itself) slightly more (although 1238f13 has 2 utACKs )
sipa deleted the branch on Jun 23, 2017
PastaPastaPasta referenced this in commit a6338e296a on Jul 5, 2019
PastaPastaPasta referenced this in commit 9181716321 on Jul 5, 2019
PastaPastaPasta referenced this in commit 2d0a821811 on Jul 6, 2019
PastaPastaPasta referenced this in commit 9ea2fe2ffd on Jul 8, 2019
PastaPastaPasta referenced this in commit 2cf8e2f714 on Jul 9, 2019
PastaPastaPasta referenced this in commit a0bc91a578 on Jul 9, 2019
barrystyle referenced this in commit f2f3d2c5bb on Jan 22, 2020
zkbot referenced this in commit 311a079dd5 on Oct 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10189 devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private.#10321 Use FastRandomContext for all tests