bitcoin-qt.exe -? message box height is too large / layout ugly #1049

issue Diapolo opened this issue on April 6, 2012
  1. Diapolo commented at 12:53 AM on April 6, 2012: none

    On my screen (1680 * 1050) I don't even see the OK button. That message box needs a re-design or we need something that is better suited. The commands should be somehow grouped so that the ones belonging together are shown one below the other.

    Perhaps we could use more messageboxes and each one shows only a certain group of switches and explanations? @laanwj Is a tabbed messagebox possible?

  2. laanwj commented at 5:21 AM on April 6, 2012: member

    https://qt-project.org/doc/qt-4.8/qmessagebox.html

    You can pass a setInformativeText / setDetailedText. The detailed text will be in a scrollable area, which is suited to this (show the main arguments in the main area, then expand for more details).

    Only do this if you don't have to add too much code, I don't want to add a custom message box class (for example) for one rare case on one OS.

  3. laanwj commented at 5:37 AM on April 6, 2012: member

    Maybe this is a good opportunity to move the help functionality out of AppInit2. We already want to move most of the initialization to another thread eventually, so it helps to split it to multiple parts. Arguments parsing should of course remain in the GUI (main) thread.

    So I propose:

    • Add a HelpMessage() call to the Bitcoin core, that returns help text (it could return multiple texts of you want to split it into main/detailed)
    • Call it from bitcoin-qt when '-?' or '--help' option is provided (after the translators are loaded, probably before the splash screen shows)
    • Show the message box in any way you want

    This also prevents having to add extra arguments to the ThreadSafeMessageBox call chain.

  4. sipa commented at 11:11 AM on April 6, 2012: member

    @laanwj sounds like a good idea

  5. laanwj referenced this in commit 6cfe909b3f on May 13, 2012
  6. laanwj referenced this in commit 4bd638307d on May 13, 2012
  7. laanwj referenced this in commit 3514f40375 on May 13, 2012
  8. laanwj referenced this in commit 842e5c7ab1 on May 13, 2012
  9. laanwj referenced this in commit 694dcb6e26 on May 13, 2012
  10. laanwj referenced this in commit 9f5b11e6fd on May 13, 2012
  11. Diapolo commented at 6:32 AM on May 15, 2012: none

    @laanwj This got much better, but the work-around you use to set a width is really ugly ^^. I tried to search the web, but found no good solution to this. I'll give it another try and if I find nothing I'll close this one.

  12. laanwj commented at 6:37 AM on May 15, 2012: member

    I've already tried a few things. It's the only workaround that works. It's an OS-level message box, there is no fine control over it. Any other workaround would amount to re-implementing the message box, which would be even more code and just not worth it.

    Feel free to completely remove it though if the default width is fine on Windows.

  13. Diapolo commented at 11:23 AM on May 18, 2012: none

    I added a few more nonbreaking spaces in my test-build, which looks okay so far. I'm working on that part, but before I open another pull it would be good if #1323 could get into master, can you have a look at it?

  14. Diapolo commented at 2:31 PM on June 1, 2012: none

    I consider this "fixed" after #1364 gets in, so closed!

  15. Diapolo closed this on Jun 1, 2012

  16. coblee referenced this in commit cc4c944b0f on Jul 17, 2012
  17. suprnurd referenced this in commit 231532d6d0 on Dec 5, 2017
  18. ptschip referenced this in commit 799a317f67 on May 1, 2018
  19. lateminer referenced this in commit 521d13b6f0 on May 6, 2020
  20. lateminer referenced this in commit cb332cc11c on May 6, 2020
  21. lateminer referenced this in commit 3ea8c577d4 on May 6, 2020
  22. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me