Docs: Update INSTALL.md to add link to build notes #10541

pull ABISprotocol wants to merge 2 commits into bitcoin:master from ABISprotocol:patch-1 changing 1 files +1 −1

ABISprotocol commented at 4:03 PM on June 6, 2017: none

No description provided.
Update INSTALL.md to add link to developer notes b0a24f076d
fanquake added the label Docs and Output on Jun 6, 2017
MarcoFalke renamed this:
~~Docs: Update INSTALL.md to add link to dev notes~~
Docs: Update INSTALL.md to add link to build notes
on Jun 6, 2017

Minor changes to INSTALL.md

This changes patch-1 branch as originally proposed and suggests minor changes to INSTALL.md

898ffb421a

in INSTALL.md:4 in b0a24f076d outdated

   0 | @@ -1,5 +1,5 @@
   1 |  Building Bitcoin
   2 |  ================
   3 |  
   4 | -See doc/build-*.md for instructions on building the various
   5 | +See doc/build-*.md or [link here](https://github.com/bitcoin/bitcoin/blob/57b34599b2deb179ff1bd97ffeab91ec9f904d85/doc/README.md#building) for instructions on building the various

MarcoFalke commented at 4:21 PM on June 6, 2017:

Please make the link relative to the git root:

[link](/doc/README.md)

laanwj commented at 4:31 PM on June 7, 2017:

Right, including a specific commit is id not a good idea because it essentially freezes the build instructions in time.

ABISprotocol commented at 6:24 AM on June 13, 2017:

Thanks, am correcting.

laanwj commented at 10:28 AM on June 13, 2017: member

Now you removed the link completely, why?
ABISprotocol commented at 5:05 AM on June 14, 2017: none

@laanwj I was under the impression from the discussion the link wasn't preferred, but if it is considered to be alright then I can walk it back in - in other words, I can change it to link relative to git root as @MarcoFalke suggested.
laanwj commented at 6:19 AM on June 14, 2017: member

I can change it to link relative to git root as @MarcoFalke suggested.

Yes, why not just follow his suggestion. Our only comment was that you shouldn't link to a specific revision, nor have to include the github part.
laanwj commented at 3:03 PM on June 22, 2017: member

Going to close this. It's taking too long for a one-line change.
laanwj closed this on Jun 22, 2017
ABISprotocol commented at 2:45 AM on July 3, 2017: none

Sorry about the length of time @laanwj I got insanely busy and then literally couldn't get back to it. My sincere apologies. Some other time perhaps on something similar. Cheers and happy 4th.
ABISprotocol deleted the branch on Jul 3, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels