Removes stats about leveldb, univalue, and benchmark coverage from the coverage reports. Since we don't test these three items specifically and thus don't care about test coverage for these items.
This builds on top of #10511 to use the faster lcov -r replacement.
Added an option to configure to allow for branch coverage statistics gathering.
Disabled logprint macro when coverage testing is on so that unnecessary branches are not analyzed.
Perhaps remove all the subtrees... including src/crypto/ctaes and src/secp256k1?
Removed ctaes and secp256k1 too.
17 | + with open(outfile, 'w') as wf: 18 | + for line in f: 19 | + for p in pattern: 20 | + if line.startswith("SF:") and p in line: 21 | + in_remove = True 22 | + if not in_remove:
This line should probably not be inside the for p in pattern: loop, as it may result in multiple writes of the same input line.
Instead of using lcov -r (which is extremely slow), first use a python script to perform bulk cleanup of the /usr/include/* coverage. Then use lcov -a to remove the duplicate entries. This has the same effect of lcov -r but runs significantly faster
Concept ACK
Remove leveldb baseline coverage gathering.
Added filter rules to remove all of the subtress (leveldb, secp256k1, ctaes, univalue) and
benchmarking from the coverage report. These items are unnecessary as we do not test for any
of the subtrees and benchmark coverage is unneeded.
170 | @@ -171,44 +171,32 @@ baseline.info: 171 | $(LCOV) -c -i -d $(abs_builddir)/src -o $@ 172 | 173 | baseline_filtered.info: baseline.info 174 | - $(abs_builddir)/contrib/filter-lcov.py "/usr/include/" $< $@ 175 | + $(abs_builddir)/contrib/filter-lcov.py -p "/usr/include/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1" $< $@
Perhaps abstract out the list of things to filter into a variable, as it's used more than once?
done
Tested ACK d5711f4a2d59adc45755b13e3776b9d36e1c55f5