[RPC] Split signrawtransaction into multiple distinct RPCs #10570

issue achow101 openend this issue on June 10, 2017
  1. achow101 commented at 4:10 am on June 10, 2017: member

    The current signrawtransaction rpc command is kind of a mess. It contains both wallet code and non-wallet code as well as an undocumented feature to combine multiple transactions. This issue is to track progress on this and to get some commentary on this split.

    The goal of this is to result in the following (and probably in this order):

    • Split combination of transactions into a new RPC that also handles the combination (#10571)
    • Split signrawtransaction into wallet and non-wallet RPCs. (#10579)
    • Mark signrawtransaction as deprecated (#10579)
    • Remove signrawtransaction (#12490)
  2. sipa commented at 4:17 am on June 10, 2017: member

    One idea would be to combine this with a new partial transaction format (using header byte 0xff rather than 0x00?), which can contain redundant information:

    • The UTXOs being spent (so that the signer doesn’t need access to the UTXO set)
    • The redeemscript in case of P2SH/witness outputs.
    • Which output(s) to send change to (before it’s known how much that change will be).
  3. achow101 commented at 7:52 am on June 10, 2017: member
    @sipa that would be out of scope for this. Such a format could be added later. This issue is really only for the cleanup of the mess that is signrawtransaction
  4. fanquake added the label RPC/REST/ZMQ on Jun 11, 2017
  5. laanwj referenced this in commit adf170daf9 on Jul 20, 2017
  6. sipa referenced this in commit ffc6e48b29 on Feb 20, 2018
  7. achow101 commented at 4:30 am on September 7, 2018: member
    Closing now that #12490 has been merged
  8. achow101 closed this on Sep 7, 2018

  9. PastaPastaPasta referenced this in commit 0c60a6820f on Sep 16, 2019
  10. PastaPastaPasta referenced this in commit 6478562b3d on Sep 18, 2019
  11. codablock referenced this in commit 555eb28f6e on Sep 20, 2019
  12. codablock referenced this in commit c054f8f5dc on Sep 22, 2019
  13. codablock referenced this in commit 8308012e18 on Sep 23, 2019
  14. barrystyle referenced this in commit dd946c5491 on Jan 22, 2020
  15. PastaPastaPasta referenced this in commit 3f66e7da20 on Dec 11, 2020
  16. PastaPastaPasta referenced this in commit fc96339839 on Dec 12, 2020
  17. PastaPastaPasta referenced this in commit 38ca3c214e on Dec 12, 2020
  18. PastaPastaPasta referenced this in commit b4f67a5e9e on Dec 15, 2020
  19. PastaPastaPasta referenced this in commit a2f107424b on Dec 15, 2020
  20. PastaPastaPasta referenced this in commit d977daaff0 on Dec 18, 2020
  21. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me