qa: Add stopatheight test #10632

  47 |          self._test_getnetworkhashps()
  48 | -        self.nodes[0].verifychain(4, 0)
  49 | +        self._test_stopatheight()
  50 | +        assert self.nodes[0].verifychain(4, 0)
  51 | +
  52 | +    def _test_stopatheight(self):

jnewbery commented at 8:59 AM on June 20, 2017:

micronit: The other subtests are defined in the order that they're called. Perhaps place this definition after the other subtests?

 138 | +        assert_equal(self.nodes[0].getblockcount(), 200)
 139 | +        self.nodes[0].generate(6)
 140 | +        assert_equal(self.nodes[0].getblockcount(), 206)
 141 | +        self.log.debug('Node should not stop at this height')
 142 | +        assert_raises(subprocess.TimeoutExpired, lambda: bitcoind_processes[0].wait(timeout=3))
 143 | +        self.nodes[0].generate(1)

sdaftuar commented at 1:47 AM on June 23, 2017:

I believe this call to generate might fail -- isn't it possible the node's shutdown will interrupt the RPC response? That looks to me like what happened here: https://travis-ci.org/bitcoin/bitcoin/jobs/245917226#L2275

I think we should wrap the generate(1) in a try...except and allow for the RPC to fail due to connection refused, etc.