[qa] util: Check return code after closing bitcoind proc #10636

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1706-qaTraceback changing 1 files +1 −1

MarcoFalke commented at 11:57 AM on June 20, 2017: member

Just a minor cleanup.

This has no effect on the outcome of test cases, but prints shorter and less confusing tracebacks on fails.

I.e. does not print an obvious "ConnectionRefusedError" when shutting down the nodes due to an invalid return code.

[qa] util: Check return code after closing bitcoind proc

This has no effect on the outcome of test cases, but
prints shorter and less confusing tracebacks on fails.

I.e. does not print an obvious "ConnectionRefusedError"
when shutting down the nodes due to an invalid return code.

999923e4bb

MarcoFalke added the label Tests on Jun 20, 2017
laanwj commented at 2:12 PM on June 22, 2017: member

Nice, that has been a frequent annoyance, surprised it was so simple to solve. utACK 999923e
MarcoFalke merged this on Jun 22, 2017
MarcoFalke closed this on Jun 22, 2017
MarcoFalke referenced this in commit 4bc853b50f on Jun 22, 2017
sdaftuar commented at 6:22 PM on June 22, 2017: member

post-merge utACK
MarcoFalke deleted the branch on Jun 22, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10678 zapwallettxes.py test failure due to bitcoind return code