Call RandomInit() in bench_bitcoin to initialize the RNG so that it does not cause an assertion error.
Initialize randomness in benchmarks #10662
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:fix-bench changing 1 files +2 −0-
achow101 commented at 9:21 PM on June 23, 2017: member
-
5155d1101e
Initialize randomness in benchmarks
Call RandomInit() in bench_bitcoin to initialize the RNG so that it does not cause an assertion error.
-
sipa commented at 10:59 PM on June 23, 2017: member
utACK 5155d1101eb4fc9d4d797b583bb29f71807bd10b
-
theuni commented at 12:47 AM on June 24, 2017: member
Caught one! :)
utACK 5155d1101eb4fc9d4d797b583bb29f71807bd10b
-
sipa commented at 12:52 AM on June 24, 2017: member
Caught one! :)
Yes, not using hardware randomness in our benchmarks would indeed be devastating for security.
... Ok, I'll concede having an assertion was a good idea.
- MarcoFalke added the label Tests on Jun 24, 2017
- MarcoFalke merged this on Jun 24, 2017
- MarcoFalke closed this on Jun 24, 2017
- MarcoFalke referenced this in commit e0a7801223 on Jun 24, 2017
- achow101 deleted the branch on Aug 29, 2017
- PastaPastaPasta referenced this in commit c62c7ab6d6 on Sep 3, 2019
- barrystyle referenced this in commit 7d921f924f on Jan 22, 2020
- MarcoFalke locked this on Sep 8, 2021
