Pow: Introduce MaybeGenerateProof #10669

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:b14-pow-maybe-prove changing 3 files +20 −10

jtimon commented at 8:55 AM on June 25, 2017: contributor

This simplifies generateBlocks and further encapsulates the use of nNonce and nBits inside pow.o by introducing a new function MaybeGenerateProof.

This should be helpful for any attempt to support a testnet with signed blocks (see #9177 )
fanquake added the label Refactoring on Jun 25, 2017
fanquake added the label Mining on Jun 25, 2017
meshcollider commented at 2:54 AM on August 26, 2017: contributor

utACK https://github.com/bitcoin/bitcoin/pull/10669/commits/f91c9df38bfb74c897896a0d0c59a77539e9e26a

in src/pow.cpp:102 in f91c9df38b outdated

  97 | +    while (max_tries > 0 && pblock->nNonce < nInnerLoopCount && !CheckProofOfWork(blockHash, pblock->nBits, params)) {
  98 | +        ++pblock->nNonce;
  99 | +        blockHash = pblock->GetHash();
 100 | +        --max_tries;
 101 | +    }
 102 | +    return CheckProofOfWork(blockHash, pblock->nBits, params);

sipa commented at 7:41 PM on August 27, 2017:

It seems unnecessary to call CheckProofOfWork twice. You can move it from the while loop into the body, and make it return true immediately when it succeeds.

jtimon force-pushed on Aug 28, 2017
jtimon commented at 11:15 PM on August 28, 2017: contributor

Fixed @sipa 's nit.
jtimon force-pushed on Jan 9, 2018
jtimon commented at 4:06 AM on January 9, 2018: contributor

Rebased for no reason.
Pow: Introduce MaybeGenerateProof 2382bf75a0
jtimon force-pushed on Jan 31, 2018
MarcoFalke commented at 2:45 PM on May 18, 2018: member

Closing for now due to inactivity. We can reopen, when there is more appetite.
MarcoFalke closed this on May 18, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9177 NOMERGE: WIP: Support block signed custom testchains