document script-based return fields for validateaddress #10676

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:validatata changing 1 files +8 −0

instagibbs commented at 3:27 AM on June 27, 2017: member

No description provided.
fanquake added the label Docs and Output on Jun 27, 2017
laanwj commented at 12:06 PM on June 28, 2017: member

utACK f9dc6e5
laanwj assigned laanwj on Jun 28, 2017
document script-based return fields for validateaddress f2f1d0a83e
in src/rpc/misc.cpp:177 in f9dc6e5d68 outdated
```
 173 | @@ -174,6 +174,14 @@ UniValue validateaddress(const JSONRPCRequest& request)
 174 |              "  \"ismine\" : true|false,        (boolean) If the address is yours or not\n"
 175 |              "  \"iswatchonly\" : true|false,   (boolean) If the address is watchonly\n"
 176 |              "  \"isscript\" : true|false,      (boolean) If the key is a script\n"
 177 | +            "  \"script\" : \"type\"           (string, optional) The output script type. Possible types: nonstandard, pubkey, pubkeyhash, scripthash, multisig, nulldata, witness_v0_keyhash, witness_v0_scripthash\n"
```
jonasschnelli commented at 8:16 PM on June 28, 2017:

I guess this and L178 needs two whitespace more for the correct indentation...

instagibbs commented at 8:37 PM on June 28, 2017:

I don't see the mis-alignment here?

jonasschnelli commented at 3:22 PM on June 29, 2017:

L176 has two escapes (2x \") while this line has four escapes. I'd expect that it will be off by two whitespace against the other lines.

instagibbs commented at 3:25 PM on June 29, 2017:

I'm matching lines 185 through 187 at least, should those be indented further as well?

jonasschnelli commented at 6:58 PM on June 29, 2017:

This is how it looks. Mind the \". <img width="750" alt="bildschirmfoto 2017-06-29 um 20 57 24" src="https://user-images.githubusercontent.com/178464/27705229-917574e0-5d0d-11e7-8950-cf93b8a9166d.png">

Sorry for the bike-shed :)
instagibbs force-pushed on Jun 30, 2017
instagibbs commented at 12:43 PM on June 30, 2017: member

@jonasschnelli nit addressed
laanwj merged this on Jul 11, 2017
laanwj closed this on Jul 11, 2017
laanwj referenced this in commit 379aed0e53 on Jul 11, 2017
PastaPastaPasta referenced this in commit a3b0cc1f57 on Jul 6, 2019
PastaPastaPasta referenced this in commit 5ea12072d3 on Jul 8, 2019
PastaPastaPasta referenced this in commit 57ca67fcda on Jul 9, 2019
PastaPastaPasta referenced this in commit 6b1d536522 on Jul 11, 2019
PastaPastaPasta referenced this in commit 46a419da99 on Jul 13, 2019
PastaPastaPasta referenced this in commit 81c8febbc1 on Jul 17, 2019
PastaPastaPasta referenced this in commit c6a026e09a on Jul 17, 2019
PastaPastaPasta referenced this in commit cf40b5409c on Jul 18, 2019
barrystyle referenced this in commit f536583ef8 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels