Fix missing headers in addrman and netbase #1068

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:headers changing 4 files +41 −25

luke-jr commented at 2:07 PM on April 9, 2012: member

No description provided.
Fix missing headers in addrman and netbase 9657fc1e7f
in src/netbase.h:None in 9657fc1e7f
```
  21 | -#include <ifaddrs.h>
  22 | -#endif
  23 | -#ifdef BSD
  24 | -#include <netinet/in.h>
  25 | -#endif
  26 | -
```
sipa commented at 7:08 PM on April 10, 2012:

How to get definitions for struct sockaddr_in and in_addr then?

luke-jr commented at 8:14 PM on April 10, 2012:

Not needed for the header, I think? Maybe changes with IPv6...
in src/util.h:None in 9657fc1e7f
```
  25 | @@ -26,6 +26,8 @@
  26 |  
  27 |  #include "netbase.h"
  28 |  
  29 | +class CNetAddr;
```
sipa commented at 7:09 PM on April 10, 2012:

This seems unnecessary: class CNetAddr after including netbase.h.

luke-jr commented at 8:14 PM on April 10, 2012:

It was necessary when netbase.h included util.h.
jgarzik commented at 4:23 PM on April 15, 2012: contributor

This is not a NAK... but I don't really think this is much needed
jgarzik commented at 11:48 PM on April 15, 2012: contributor

Superceded by #1109. Anything remaining should be on top of that.
jgarzik closed this on Apr 15, 2012
suprnurd referenced this in commit d5dcf2b668 on Dec 5, 2017
sanch0panza referenced this in commit 7d64cf3371 on May 17, 2018
lateminer referenced this in commit 59b45e6d33 on Nov 7, 2019
Bushstar referenced this in commit 5fe9840e7e on Feb 26, 2020
DrahtBot locked this on Sep 8, 2021

Contributors