I noticed that bip65-cltv-p2p.py was setting extra_args, but the ComparisonTestFramework was silently ignoring it. Though I think this framework is likely going to be decommissioned, this is easy enough to fix for now.
[qa] Bugfix: allow overriding extra_args in ComparisonTestFramework #10690
pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2017-06-comp-framework-extraargs changing 1 files +4 −2-
sdaftuar commented at 2:02 PM on June 28, 2017: member
-
[qa] Bugfix: allow overriding extra_args in ComparisonTestFramework 4ed36539bc
- fanquake added the label Tests on Jun 28, 2017
-
jnewbery commented at 2:39 PM on June 28, 2017: member
Tested ACK 4ed36539bcdebb360c730b2492b6435d7cd2476c
-
laanwj commented at 3:40 PM on June 28, 2017: member
utACK https://github.com/bitcoin/bitcoin/pull/10690/commits/4ed36539bcdebb360c730b2492b6435d7cd2476c
(I'm surprised the test was not failing with the wrong command line)
-
sdaftuar commented at 3:51 PM on June 28, 2017: member
(I'm surprised the test was not failing with the wrong command line)
So was I! That test needs to be overhauled in general though, as it makes no sense now that BIP65 activates on a specific height.
-
MarcoFalke commented at 4:12 PM on June 28, 2017: member
utACK 4ed3653
- MarcoFalke merged this on Jun 28, 2017
- MarcoFalke closed this on Jun 28, 2017
- MarcoFalke referenced this in commit 416af3edf5 on Jun 28, 2017
- codablock referenced this in commit 2b66fc6641 on Jun 23, 2019
- barrystyle referenced this in commit 128b43375e on Jan 22, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels