I use a dark theme. Light text on a dark background.
The recent change to the blockchain download status bar makes it hard to read due to the white text on bright orange background.
If we're going to specify the background colour, we should also specify the text colour, or we risk making the text invisible.
Here's how it looks to me:
I'd prefer to see a smart way to leave the OS default processbar colour alone... Any details on what the exact problem encountered was?
The bright orange is horribly ugly on my monochrome theme. I'd prefer to have the process bar fit in with the theme, not be bright orange.
I think #1025 (comment) in #1025 was the initial reason for the redesign.
I submitted #1030 which left the style alone and just changed the text, but this was after #1025 had already done the redesign. I just hadn't seen #1025 at the time.
The default progressbar design is unreadable on quite a few OSes, sipa observed problems with it and on Win7 I also couldn't read it. That's why we changed to the current design ...
Fair enough, but shouldn't you control both the foreground and the background, rather than just hoping the default foreground contrasts with your chosen background?
As far as I remember, the Qt specs didn't mention you could set the text color, too. If it's possible that could be added, sure.
This seems to work:
progressBar->setStyleSheet("QProgressBar { color: red; background-color: transparent; ...
But since the bar is transparent, there's still the problem of having the text needing to show up against both the orange you specify and the background colour that you don't know. So:
progressBar->setStyleSheet("QProgressBar { color: black; background-color: white; ...
I know it's a problem to ensure readability on all default OS themes + don't make it look ugly ... but a white background feels kind of ugly ^^.
I don't really care what colours you pick so long as you pick some that make the text readable. Leaving one of the three colours to be decided by the OS vendor isn't a good idea.
I have to agree, but I'm not sure how to chose the best colorisation for this problem :-/.
I wonder how difficult it would be, to use the default style with an opacity of 50% so the window background brightness shows through?
I think opacity requires OS support for transparent windows and there are OSes and themes, which don't support that at all.
Qt makes it possible to query what styling engine is used. I think it makes sense to only apply custom styling in the specific case of the QWindowsVistaStyle engine.
Otherwise, simply rely on the default to do the right thing.
Talk to sipa, guess he uses some Linux, which also had unreadable text with the used theme. I'm fine with OS defaults, as long as text is readable. I really love orange though :-D.
Arguably it is a problem with the theme or Qt and not with Bitcoin if text on the progress bar is unreadable, it is a common enough use-case.
Orange kind of fits with the rest of the icons in the status bar, and the color of the bitcoin icon. It's not the color that is the problem, it is that this fix causes other (otherwise well-behaved themes) to break.
Well at least I assume so. @dooglus, what happens if you completely remove the setStyleSheet line?
This:
and when almost done, this:
... which is perfectly OK, I guess? (except that maybe the progress bar should be wider, but that's a completely different thing)
Yes. I deliberately narrowed the window so the ~ would be partially within the dark area of the progress bar.
And the green checkmark shouldn't be there when 8 blocks are remaining. I think I made a separate issue (#921) for that.
As I'm going to be off for 7 days tomorrow, you are free to create a pull-request, which only replaces default style, when there are problems with readability. We could aswell add a small option into the settings -> display to set default or our theme for the bar?
That's fine. I propose that we handle the exceptions on a case-by-case basis. @sipa can you comment what environments exactly have the readability issue with the default style sheet?
No option for this, please. That'd be lazy and shoveling the trouble on the user.
See you in a week!
On Ubuntu and Kubuntu (default theme) it is also readable by default:
If there are themes where it isn't readable, that's not a Bitcoin bug, but a theme bug. I'm not sure we should be doing anything about bugs in themes, other than reporting them in the appropriate place.
Ok, on Ubuntu 11.10, xmonad, it looks like this: http://bitcoin.sipa.be/bitcoinqt.png after merging #1091.
