Move script flag to/from-string logic from tests to script/interpreter #10730

1. 
   luke-jr commented at 8:32 am on July 3, 2017: member

   When we last discussed making scripts debuggable (sometime after #3901), the plan was to instead trace execution rather than single-step through it.

   This is a dependency step toward that, and is eventually used for the RPC verifyscript to parse its "flags" option.

   See also #10729

2. fanquake added the label Validation on Jul 3, 2017
3. 
   jonasschnelli commented at 7:26 am on July 13, 2017: contributor

   Needs rebase
4. luke-jr force-pushed on Sep 2, 2017
5. 
   luke-jr commented at 4:37 am on September 2, 2017: member

   Rebased
6. 
   laanwj commented at 10:23 pm on September 6, 2017: member

   I’m okay with moving this out of the tests if it’s necessary in another place, however the from/to string stuff doesn’t belong with the interpreter consensus code IMO. Better to keep it in a separate compilation unit, like with the CBitcoinAddress split done in #11117.
7. 
   laanwj commented at 9:01 am on November 20, 2017: member

   @luke-jr ping?
8. 
   luke-jr commented at 9:39 pm on November 20, 2017: member

   Hmm, so where would you suggest? Bundle it in with RPC-specific stuff?
9. script: Move SCRIPT_VERIFY_* enum to its own header file (script/script_flags.h) ebf9ef5943
10. Move script flag to/from-string logic from tests to script/script_flags 63d90f4c46
11. Rename "P2SH" script flag (string only) to "BIP16"

    P2SH is a general term, and can be applied to Segwit program v0 of 32 bytes too

    e2e183bc1f
12. luke-jr force-pushed on Apr 1, 2018
13. 
    luke-jr commented at 7:06 am on April 1, 2018: member

    Rebased, and moved it to script/script_flags.{h,cpp} for now.
14. MarcoFalke added the label Needs rebase on Jun 6, 2018
15. 
    luke-jr commented at 6:13 pm on June 16, 2018: member

    Closing due to apparent lack of interest/reviewers
16. luke-jr closed this on Jun 16, 2018

    ---

17. laanwj removed the label Needs rebase on Oct 24, 2019
18. DrahtBot locked this on Dec 16, 2021

Contributors
luke-jr jonasschnelli laanwj

Labels
Validation