[wallet] Change bumpfee totalFee option to feeRate option #10750

pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:bumpfeerate changing 7 files +57 −38
  1. instagibbs commented at 6:42 PM on July 5, 2017: member

    Using a total fee argument is of dubious utility and also makes further improvements where you are changing inputs/outputs difficult. To use the previous argument successfully the user must do additional math, rather than taking any fee estimate desired and plugging it in

    Did satoshis/byte since totalFee was satoshis.

  2. Add GetRequiredFeeRate function, use in GetRequiredFee 7f610b5d04
  3. morcos commented at 6:46 PM on July 5, 2017: member

    @instagibbs I think this is intentionally a total fee. There are BIP 125 requirements both for the fee rate and the total fee of the replacement transaction, but the one that is more likely to cause an issue is the total fee because it requires looking at all the descendant transactions of the original. Thus if manually specifying the replacement transaction, you have clearer control by specifying the total fee.

  4. Change bumpfee totalFee option to feeRate option b12a3ea02e
  5. instagibbs force-pushed on Jul 5, 2017
  6. instagibbs commented at 8:20 PM on July 5, 2017: member

    After much discussion, it seems that this can not be gotten rid of(yet), so I will close for now. Subsequent improvements may just have to route around this feature.

  7. instagibbs closed this on Jul 5, 2017

  8. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me