Use vector::data() instead of &vch[0] in base58.cpp #10790

pull meshcollider wants to merge 1 commits into bitcoin:master from meshcollider:prefer-vector-data changing 2 files +7 −7

meshcollider commented at 3:23 AM on July 11, 2017: contributor

&vch[0] has undefined behavior for empty vectors, c++11 introduced data() as a safer alternative

EncodeBase58(const std::vector<unsigned char>& vch) didn't check for empty vectors before using &vch[0] so suggest replacing with data() in this file, also makes it consistent with base58_tests.cpp
Prefer vch.data() over &vch[0]in base58 0e0bc80cbc
laanwj added the label Refactoring on Jul 11, 2017
laanwj commented at 7:18 AM on July 11, 2017: member

Have you checked that this doesn't overlap with #9804? If it does, please review that one instead.
meshcollider commented at 8:16 AM on July 11, 2017: contributor

Ah it does, missed that sorry. Closing this then.
meshcollider closed this on Jul 11, 2017
meshcollider deleted the branch on Jul 11, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels