Expand gettxout to also serve spent txo if pruning or lack of -txindex don’t get in the way.
If the output is spent, it will be slower to load, but there’s no reason not to serve this if the data is there.
TODO (functional tests):
-txindex. This functionality is already available through getrawtransaction anyway.
I don’t think we should be expanding the impact of -txindex.
Is there a problem with that? This is just RPC anyway. I also think making -txindex more useful may increase the incentives to run an archive full node.
My reasoning (with some errors corrected below it) is here: #9806 (comment)
This functionality is already available through getrawtransaction anyway.
By that logic, shouldn’t we just fully remove gettxout? That would be bad for gettxoutbyscript and gettxoutbyaddress though, I think.
gettxout is faster for utxo, so if one wants a txo (not knowing if stxo/utxo a priori), one could call gettxout first and only if it fails call getrawtransation. But I think a single call would be more convenient. If not, I guess we need getoutpointfromscript and getoupointfrom address call too to serve the full txo. One could, for example, call gettxoutbyaddress and if it fails, also call gettxoutbyaddress and getrawtransaction. It would be more cumbersome, but it would also work.
1015@@ -987,6 +1016,12 @@ UniValue gettxout(const JSONRPCRequest& request)
1016 if (request.params.size() > 2)
1017 fMempool = request.params[2].get_bool();
1018
1019+ bool include_spent = false;
1020+ if (request.params.size() > 3) {
0if (!request.params[3].isNull()) {
1047@@ -1013,6 +1048,7 @@ UniValue gettxout(const JSONRPCRequest& request)
1048 ScriptPubKeyToUniv(coin.out.scriptPubKey, o, true);
1049 ret.push_back(Pair("scriptPubKey", o));
1050 ret.push_back(Pair("coinbase", (bool)coin.fCoinBase));
1051+ ret.push_back(Pair("spent", (bool)is_spent));
45@@ -46,6 +46,33 @@ static CUpdatedBlock latestblock;
46
47 extern void TxToJSON(const CTransaction& tx, const uint256 hashBlock, UniValue& entry);
48
49+static bool ReadTxoFromOutpoint(Coin& coin, bool& is_spent, const CBlockIndex* pindex, const COutPoint& out, bool include_spent)
pindex not used.
977- "2. n (numeric, required) vout number\n"
978- "3. include_mempool (boolean, optional) Whether to include the mempool\n"
979+ "1. \"txid\" (string, required) The transaction id\n"
980+ "2. \"n\" (numeric, required) vout number\n"
981+ "3. \"include_mempool\" (boolean, optional) Only search in the mempool. Default: true\n"
982+ "4. \"include_spent\" (boolean, optional) Whether to include spent outputs. Default: false\n"
include_mempool is false.
1015@@ -987,6 +1016,12 @@ UniValue gettxout(const JSONRPCRequest& request)
1016 if (request.params.size() > 2)
1017 fMempool = request.params[2].get_bool();
1018
1019+ bool include_spent = false;
1020+ if (request.params.size() > 3) {
1021+ include_spent = request.params[3].get_bool();
1022+ }
1023+
1024+ bool is_spent = false;
955+bool GetTransaction(const uint256 &hash, CTransactionRef &txOut, const Consensus::Params& consensusParams, uint256 &hashBlock, bool fAllowSlow)
956+{
957+ LOCK(cs_main);
958+
959+ CTransactionRef ptx = mempool.get(hash);
960+ if (ptx)
0if (ptx) {
18@@ -19,6 +19,7 @@ def __init__(self):
19 self.setup_clean_chain = True
20 self.num_nodes = 4
21 self.extra_args = [['-usehd={:d}'.format(i%2==0)] for i in range(4)]
22+ self.extra_args[0].append('-txindex')
1015@@ -987,6 +1016,12 @@ UniValue gettxout(const JSONRPCRequest& request)
1016 if (request.params.size() > 2)
1017 fMempool = request.params[2].get_bool();
1018
1019+ bool include_spent = false;
1020+ if (request.params.size() > 3) {
1021+ include_spent = request.params[3].get_bool();
1022+ }
Disallow include_spent if include_mempool:
0 if (fMempool && include_spent) {
1 throw JSONRPCError(RPC_INVALID_PARAMETER, "...");
2 }
If you add this, update test below.
947@@ -955,6 +948,23 @@ bool GetTransaction(const uint256 &hash, CTransactionRef &txOut, const Consensus
948 return false;
949 }
950
951+/**
952+ * Return transaction in txOut, and if it was found inside a block,
953+ * its hash is placed in hashBlock. Look in the mempool first.
954+*/
955+bool GetTransaction(const uint256 &hash, CTransactionRef &txOut, const Consensus::Params& consensusParams, uint256 &hashBlock, bool fAllowSlow)
Needs rebase and has nits but since I didn’t heard any enthusiasm for more functionality regarding -txindex and @sipa was negative about it, I am closing this for now. @promag thanks for the review and your nits will be taken into account if I ever reopen this.
EDIT: Happy to reopen if people want it (perhaps after/if there’s an index for scriptPubKey -> txid:n )
Labels
RPC/REST/ZMQ