Update translations for bitcoin core #1089

laanwj commented at 6:50 AM on April 13, 2012: member

Update translations for bitcoin core
Move scripts/qt to share/qt, to clean up toplevel directories
Update english ts file which is used to source messages for Transifex
In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed

This will not break any current translations, but will allow new messages to be translated.

Diapolo commented at 10:53 AM on April 13, 2012: none

Im fine with wthis change in general (ACK). If it get's merged #1000 (yay ^^) can be closed, too!

laanwj commented at 1:03 PM on April 13, 2012: member

I'll re-run with -no-obsolete and change Hide to lowercase.

I don't have control over which plural forms are generated.

Diapolo commented at 1:36 PM on April 13, 2012: none

Great!

I'm very sure the plural forms (english base) need to be put in the .ts directly (manual).

Am 13.04.2012 15:03, schrieb Wladimir J. van der Laan:

I'll re-run with -no-obsolete and change Hide to lowercase.

I don't have control over which plural forms are generated.

Reply to this email directly or view it on GitHub: #1089 (comment)

laanwj commented at 1:47 PM on April 13, 2012: member

Can you point to the documentation on that? It sounds unlikely; TS files are supposed to be generated automatically from the source code. (And plural forms differ per language. They cannot be sourced practically from English)

Diapolo commented at 1:59 PM on April 13, 2012: none

Look at the other plurals or numerusform tags in the en .ts file. I'm sure someone placed the translations for the existing numerusform tags in there.

It seems this can be done with Qt Linguist application (open the en .ts and search for %n second(s) ago in BitcoinGUI), as the existing translations where plural forms are used are displayed with a yellow question mark and the english translation text IS filled in for them, right?

A doc is here, but I'm not sure if that's mentioned: http://doc.qt.nokia.com/qq/qq19-plurals.html

Diapolo commented at 2:04 PM on April 13, 2012: none

It seems Qt Linguist is the tool of choice :) ... you can even say that a translation is finished, which marks the string with a green check + removes the type="unfinished" tag for finished translations (that's for english master file - translation here means you looked through, added plural forms and marked strings as finished), cool!

laanwj commented at 2:05 PM on April 13, 2012: member

Ok, you're right. I misunderstood. The _en needs to be manually updated to make the plural mechanism work in English, not to facilitate translations.

https://qt-project.org/doc/qt-4.8/linguist-programmers.html (under "Handling Plural Forms")

laanwj commented at 2:12 PM on April 13, 2012: member

Fixed; and also marked the plural forms as "finished".

Diapolo commented at 4:13 PM on April 13, 2012: none

Looks pretty good, so ACK!

Diapolo commented at 4:40 PM on April 13, 2012: none

@laanwj 1 more thing I observed while playing around in Qt Linguist, we should set the base language of our en .ts file to only english (currently set to country USA). This can be done under Edit -> Translation File Settings...:

http://i42.tinypic.com/fp5irm.jpg

Update translations for bitcoin core

- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed

3fddc8effc

laanwj commented at 6:47 AM on April 14, 2012: member

Ok, fixed too...

laanwj referenced this in commit 46ba858817 on Apr 14, 2012

laanwj merged this on Apr 14, 2012

laanwj closed this on Apr 14, 2012

coblee referenced this in commit ba0cbd416a on Jul 17, 2012

laanwj deleted the branch on Apr 9, 2014

suprnurd referenced this in commit 565fa31850 on Dec 5, 2017

dagurval referenced this in commit 162adeae32 on May 27, 2018

DrahtBot locked this on Sep 8, 2021