[RPC] Make ImportAddress works with segwit scriptPubKey #10891

pull NicolasDorier wants to merge 1 commits into bitcoin:master from NicolasDorier:importaddresswitness changing 1 files +10 −0
  1. NicolasDorier commented at 9:07 AM on July 21, 2017: contributor

    ImportAddress rpc functions does not work for segwit scirptPubKey. Worst, it fails without error.

    Reason is https://github.com/bitcoin/bitcoin/blob/041dad94b047313a17edb0324742cf80cfd550f1/src/wallet/rpcdump.cpp#L202 , if ExtractDestination fails, nothing is done.

  2. [RPC] Make ImportAddress works with segwit scriptPubKey 91dc03c7dd
  3. NicolasDorier commented at 9:32 AM on July 21, 2017: contributor

    Closing for now, I suspect my problem comes from elsewhere, will reopen once I understand better the situation.

  4. NicolasDorier closed this on Jul 21, 2017

  5. sipa commented at 4:45 PM on July 21, 2017: member

    Can you try whether #10788 helps?

  6. NicolasDorier commented at 6:07 AM on July 25, 2017: contributor

    nop, does not help.

  7. NicolasDorier commented at 6:09 AM on July 25, 2017: contributor

    trying to write a test for reproducing.

  8. fanquake added the label RPC/REST/ZMQ on Jul 25, 2017
  9. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me