resendwallettransactions asserts if walletbroadcast=0 #10981

1. 
   morcos commented at 7:30 pm on August 3, 2017: member

   There is an assert in CWalletTx::RelayWalletTransaction that gets hit. All other code paths check fBroadcastTransactions before getting to CWallet::ResendWalletTransactionsBefore except the rpc call resendwalletransactions.

   It’s an easy fix, but we just need to decide whether to throw an error or return an empty array of rebroadcasted transaction ids.

   Should be fixed for 0.15.

2. laanwj added this to the milestone 0.15.0 on Aug 3, 2017
3. fanquake added the label RPC/REST/ZMQ on Aug 5, 2017
4. laanwj closed this on Aug 7, 2017

   ---

5. laanwj referenced this in commit fa64636948 on Aug 7, 2017
6. UdjinM6 referenced this in commit 95fac106f6 on Aug 4, 2019
7. PastaPastaPasta referenced this in commit a7ef222617 on Aug 5, 2019
8. PastaPastaPasta referenced this in commit 6a12a4dd6e on Aug 6, 2019
9. PastaPastaPasta referenced this in commit 34c89f5a63 on Aug 6, 2019
10. barrystyle referenced this in commit 7835df3b01 on Jan 22, 2020
11. DrahtBot locked this on Sep 8, 2021

Contributors
morcos

Labels
RPC/REST/ZMQ

Milestone
0.15.0