Nolisten patch #11

pull ghost wants to merge 2 commits into bitcoin:master from changing 5 files +20 −9
  1. ghost commented at 1:15 pm on December 22, 2010: none

    With the current client it is impossible to start mulitple instances of bitcoin on one system, as they compete for the listen port. This patch adds a command line option to not accept bitcoin connection from outside.

    This can be useful in some cases:

    • Testing e-commerce software on the testnet with multiple clients on one machine (akin to paypal sandbox testing)
    • When multiple users on one shared server want to run the bitcoin client
    • As a primitive security measure

    Of course it would be even better to specify a port to listen on on the command line, but as I understood the current protocol has no support for alternative ports, so this would be useless.

  2. add -nolisten command line option 5f88e8887a
  3. gavinandresen commented at 2:25 pm on December 22, 2010: contributor

    Could you post a [PULL REQUEST] about this on the Dev&Tech forum: http://www.bitcoin.org/smf/index.php?board=6.0

    Until we figure out where we want to discuss pull requests (on the forum or maybe directly here), I figure it is best to do both.

  4. gavinandresen commented at 3:22 pm on December 23, 2010: contributor

    I’m a little worried that if this feature gets popular the IRC channel and the ‘addr’ messages flying across the network might be overwhelmed with the IP addresses of clients that aren’t listening. New nodes joining might then spend a long time trying and failing to connect.

    I’d be more comfortable if the patch also taught the client NOT to advertise its own IP:port on the IRC channel or via ‘addr’ broadcasts.

  5. don't advertise on IRC if we don't allow external connections 72b9861635
  6. ghost commented at 9:25 am on December 24, 2010: none

    I had originally made a forum post, with the patch attached, but the forum decided to eat it due to (invalid attachment type .patch). Then I found out about this feature :) But I’ll make a new post and simply link here.

    Valid issue about the IRC channel. I had considered that, and was under the impression that this if clause in net.cpp handled it (as in case of proxy or -connect, also no IRC connection should be made):

    0if (fUseProxy || mapArgs.count("-connect") || fNoListen)
    

    Seems I was wrong.

  7. ghost commented at 9:26 am on December 24, 2010: none
    Ah, I see the new commit (don’t connect to IRC on -nolisten) was automatically added here.
  8. cdecker commented at 10:34 pm on December 29, 2010: contributor
    Seems to me as trying to fix an intermediate problem, I’d much rather see a patch adding the ability to specify a listen port. But the patch to disable IRC bootstrapping seems nice.
  9. nelisky referenced this in commit 7cb6645e7f on Apr 4, 2013
  10. nelisky referenced this in commit 29dbd015c1 on Jul 29, 2013
  11. nelisky referenced this in commit 9747817b1a on Nov 8, 2013
  12. justmoon referenced this in commit 5bc9ac0437 on Apr 7, 2014
  13. kac- referenced this in commit 35f0a4e2e9 on Oct 8, 2014
  14. rdponticelli referenced this in commit 2ce0e50af3 on Nov 26, 2014
  15. braydonf referenced this in commit ca9da762b6 on May 20, 2016
  16. core-bitcoin referenced this in commit c11c37b0d6 on Jun 17, 2017
  17. AkioNak referenced this in commit a5610df128 on Jul 24, 2017
  18. laanwj referenced this in commit b13a68e129 on Aug 2, 2017
  19. fametrano referenced this in commit ecbd242045 on Aug 4, 2017
  20. JeremyRubin referenced this in commit 7f378349b2 on Aug 9, 2017
  21. HashUnlimited referenced this in commit fb8585691c on Mar 9, 2018
  22. KrzysiekJ referenced this in commit 58ae06661e on Mar 28, 2018
  23. sanch0panza referenced this in commit 72d50a648d on Apr 11, 2018
  24. effectsToCause referenced this in commit 78a5523c85 on Jun 22, 2018
  25. MarcoFalke referenced this in commit dc287c98f8 on Sep 7, 2018
  26. dooglus referenced this in commit 15b146b074 on Oct 21, 2018
  27. jfhk referenced this in commit c30a4aeea6 on Nov 14, 2018
  28. laanwj referenced this in commit b586bbd558 on Nov 6, 2019
  29. laanwj referenced this in commit 97b66d34eb on Nov 7, 2019
  30. laanwj referenced this in commit e9c85bb139 on Nov 7, 2019
  31. laanwj referenced this in commit c92f7af618 on Nov 7, 2019
  32. MarcoFalke referenced this in commit cf43f3f0a8 on Dec 5, 2019
  33. laanwj referenced this in commit 656712fe94 on Dec 9, 2019
  34. laanwj referenced this in commit 4abd92d5c4 on Dec 12, 2019
  35. laanwj referenced this in commit 89c8fe5189 on Jan 2, 2020
  36. laanwj referenced this in commit 66480821b3 on Jan 28, 2020
  37. Losangelosgenetics referenced this in commit 36fa31f2b8 on Mar 12, 2020
  38. KolbyML referenced this in commit 8e69d7a2ef on Aug 1, 2020
  39. KolbyML referenced this in commit 42c0c5c10e on Sep 4, 2020
  40. KolbyML referenced this in commit 47b121108f on Sep 4, 2020
  41. laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
  42. jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
  43. KolbyML referenced this in commit 3d9f0283ff on Dec 5, 2020
  44. MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
  45. MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
  46. fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
  47. MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
  48. MarcoFalke referenced this in commit c857148636 on May 15, 2021
  49. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 13:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me