[wallet] return correct error code from resendwallettransaction #11002

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:resendwallettransaction_error_code changing 1 files +1 −1
  1. jnewbery commented at 7:53 pm on August 7, 2017: member

    New code in #10995 uses RPC_INVALID_REQUEST. According to the comment in rpc/protocol.h:

    0// RPC_INVALID_REQUEST is internally mapped to HTTP_BAD_REQUEST (400).
    1// It should not be used for application-layer errors.
    

    Change the returned error code to RPC_WALLET_ERROR

    #11000 will need to be updated to test for the correct error code.

  2. [wallet] return correct error code from resendwallettransaction 055d95f842
  3. MarcoFalke added this to the milestone 0.15.0 on Aug 7, 2017
  4. MarcoFalke added the label RPC/REST/ZMQ on Aug 7, 2017
  5. MarcoFalke commented at 8:19 pm on August 7, 2017: member
    utACK 055d95f842e3659c41ad55101df8dce4865cd68f
  6. promag commented at 9:26 pm on August 7, 2017: member
    Tested ACK 055d95f.
  7. laanwj commented at 9:41 am on August 8, 2017: member
    Good catch. utACK.
  8. laanwj merged this on Aug 8, 2017
  9. laanwj closed this on Aug 8, 2017

  10. laanwj referenced this in commit 4268426b45 on Aug 8, 2017
  11. UdjinM6 referenced this in commit da63a2deac on Aug 4, 2019
  12. PastaPastaPasta referenced this in commit f1f9e5dfb5 on Aug 5, 2019
  13. PastaPastaPasta referenced this in commit 44dc84e69a on Aug 6, 2019
  14. PastaPastaPasta referenced this in commit b0aef55115 on Aug 6, 2019
  15. barrystyle referenced this in commit 0b532c71fb on Jan 22, 2020
  16. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 04:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me