qa: Fix inv race in example_test #11025

1. 
   MarcoFalke commented at 8:00 PM on August 10, 2017: member

   There have been intermittent test failures on this script.

     File "./test/functional/example_test.py", line 216, in run_test
       assert_equal(block, 1)
   AssertionError: not(2 == 1)
   

   Probably the simplest way to fix them is overriding the on_inv method, so that no "colliding" getdata for the blocks are sent out.

   Additionally, all getdata are now sent in a single message.

2. qa: Fix inv race in example_test faa76d1b79
3. MarcoFalke added the label Tests on Aug 10, 2017
4. MarcoFalke requested review from jnewbery on Aug 10, 2017
5. 
   jnewbery commented at 9:03 PM on August 10, 2017: member

   Seems reasonable. utACK faa76d1b79cc63177c8e165c9a2dc761aac7ccf4

   Thanks!

6. 
   sdaftuar commented at 2:54 PM on August 11, 2017: member

   utACK

   Perhaps we should get rid of the default on_inv behavior altogether in NodeConnCB? I don't think there's a good reason for its existence.

7. 
   MarcoFalke commented at 2:59 PM on August 11, 2017: member

   Good suggestion. Though, I am going to leave it for later, as it requires a bit more review than this small fix.

8. MarcoFalke merged this on Aug 11, 2017
9. MarcoFalke closed this on Aug 11, 2017

   ---

10. MarcoFalke referenced this in commit e5d26e47c7 on Aug 11, 2017
11. MarcoFalke deleted the branch on Aug 11, 2017
12. PastaPastaPasta referenced this in commit beeea55086 on Aug 6, 2019
13. PastaPastaPasta referenced this in commit f07077480b on Aug 6, 2019
14. PastaPastaPasta referenced this in commit 028c8ff670 on Aug 6, 2019
15. PastaPastaPasta referenced this in commit c349d0310e on Aug 7, 2019
16. PastaPastaPasta referenced this in commit 71843a020d on Aug 8, 2019
17. PastaPastaPasta referenced this in commit c2fcf849a7 on Aug 12, 2019
18. barrystyle referenced this in commit e93ae055fe on Jan 22, 2020
19. DrahtBot locked this on Sep 8, 2021

Review Requested
jnewbery