Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default #11026

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_acceptnonstd_def changing 1 files +1 −1
  1. luke-jr commented at 8:44 PM on August 10, 2017: member

    Fixes a bug introduced in #8855

    -acceptnonstdtxn is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:

    1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
    2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.

    Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.

  2. MarcoFalke added the label Docs and Output on Aug 10, 2017
  3. luke-jr force-pushed on Aug 10, 2017
  4. Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default 4aa25089b4
  5. luke-jr force-pushed on Aug 10, 2017
  6. sdaftuar commented at 12:28 PM on August 11, 2017: member

    utACK

  7. sipa commented at 10:23 PM on August 12, 2017: member

    Care to elaborate a bit?

  8. luke-jr commented at 7:52 PM on August 13, 2017: member

    -acceptnonstdtxn is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:

    1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
    2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.

    Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.

  9. achow101 commented at 11:56 PM on August 18, 2017: member

    utACK 4aa25089b4392a9a17ba5b3a8ea22e893d11d876

  10. laanwj merged this on Aug 22, 2017
  11. laanwj closed this on Aug 22, 2017

  12. laanwj referenced this in commit ea3ac5990d on Aug 22, 2017
  13. PastaPastaPasta referenced this in commit f19304eaea on Sep 19, 2019
  14. PastaPastaPasta referenced this in commit 8d7406eeb6 on Sep 23, 2019
  15. PastaPastaPasta referenced this in commit cdd561bbcf on Sep 24, 2019
  16. PastaPastaPasta referenced this in commit bc135d8a39 on Nov 19, 2019
  17. PastaPastaPasta referenced this in commit 8762895535 on Nov 21, 2019
  18. PastaPastaPasta referenced this in commit 708cc06597 on Dec 9, 2019
  19. PastaPastaPasta referenced this in commit fbbdd7722c on Jan 1, 2020
  20. PastaPastaPasta referenced this in commit 6095fcc653 on Jan 2, 2020
  21. ckti referenced this in commit 78b510303a on Mar 28, 2021
  22. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me