Just caught my eye when looking over some code. Could be a const instead of a non-const.
Consensus: add const to temp int in base58.cpp #11095
pull mdaiter wants to merge 1 commits into bitcoin:master from mdaiter:base58NuancedConst changing 1 files +1 −1-
mdaiter commented at 9:39 AM on August 19, 2017: none
-
Consensus: add const to temp int in base58.cpp 1c5b264445
- fanquake added the label Refactoring on Aug 19, 2017
- promag changes_requested
-
promag commented at 10:31 AM on August 19, 2017: member
There are other variables that can be const all over the code, and in this file too.
You could improve the description and commit message.
As is NACK.
-
laanwj commented at 8:03 AM on August 21, 2017: member
We don't regularly use
constinside functions at all. Maybe we should, but right now I don't think there is any reasoning why this value in base58 would be extra-important to warrant this change, sorry. - laanwj closed this on Aug 21, 2017
- mdaiter deleted the branch on Sep 3, 2017
- DrahtBot locked this on Sep 8, 2021
Labels