- Use >= for BIP0031 version
- Bugfix: nonce is optional in ping messages
- Don't request a pong that we ignore
BIP31 cleanups + fix #1113
pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:bip31_fixes changing 2 files +6 −10-
luke-jr commented at 4:09 PM on April 17, 2012: member
-
Use >= for BIP0031 version 6b938e847a
-
Bugfix: nonce is optional in ping messages 708c8b81cf
-
Don't request a pong that we ignore 4759fd9abe
-
jgarzik commented at 4:16 PM on April 17, 2012: contributor
disagree with all of these
-
sipa commented at 4:20 PM on April 17, 2012: member
BIP 0031 does say "can contain a nonce field". I'm not sure this is useful, but it warrants some discussion maybe.
-
luke-jr commented at 8:39 PM on April 19, 2012: member
BIP31 has been updated to make nonce mandatory (unfortunately, IMO). Closing.
- luke-jr closed this on Apr 19, 2012
- suprnurd referenced this in commit 03e4fd7539 on Dec 5, 2017
- lateminer referenced this in commit 5da7113053 on Jan 22, 2019
- lateminer referenced this in commit b546151bc0 on Dec 25, 2019
- DrahtBot locked this on Sep 8, 2021
