Enhance getinfo with regtest information #11142

pull wrapperband wants to merge 1 commits into bitcoin:0.15 from wrapperband:0.15-GetInfo-regtest changing 1 files +1 −0

wrapperband commented at 5:11 PM on August 25, 2017: none

< Bitcoin-cli getinfo > outputs information such as whether the testnet is true. This change adds regtest to the list.

Enhance getinfo with regtest information

< Bitcoin-cli getinfo > outputs information such as whether the testnet is. This change adds regtest to the list.

2493bb55df

MarcoFalke commented at 5:21 PM on August 25, 2017: member

According to the docstring, this information should be retrieved by other means.

  * [@note](/bitcoin-bitcoin/contributor/note/) Do not add or change anything in the information returned by this
  * method. `getinfo` exists for backwards-compatibility only. It combines
  * information from wildly different sources in the program, which is a mess,
  * and is thus planned to be deprecated eventually.
  *
  * Based on the source of the information, new information should be added to:
  * - `getblockchaininfo`,
  * - `getnetworkinfo` or
  * - `getwalletinfo`

MarcoFalke closed this on Aug 25, 2017
jnewbery commented at 6:19 PM on August 25, 2017: member

@wrapperband thanks for trying to help. As Marco says, getinfo is deprecated, so we don't want to add any additional fields to it. getblockchaininfo() in src/rpc/blockchain.cpp already returns a more generic chain field which tells the user which chain is being used (main, test or regtest).
wrapperband commented at 7:17 PM on August 25, 2017: none

Ok, thanks.
DrahtBot locked this on Sep 8, 2021

Contributors

wrapperband

MarcoFalke

jnewbery