Fix include path for bitcoin-config.h #11143

pull danra wants to merge 1 commits into bitcoin:master from danra:patch-5 changing 2 files +2 −3

danra commented at 5:27 PM on August 25, 2017: contributor

All the other files in the repo which include bitcoin-config.h do so with the appropriate subfolder prefixed: config/bitcoin-config.h The header should be included with the appropriate subfolder here as well.
laanwj commented at 11:40 AM on August 26, 2017: member

If you do this, please also remove the -I $srcdir/config from the build system: https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am#L21, used in https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am#L253
MarcoFalke commented at 12:05 AM on August 27, 2017: member

Please squash your commits when they are ready for merge. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
laanwj added the label Refactoring on Aug 28, 2017

Fix include path for bitcoin-config.h in crypto/common.h

All the other files in the repo which include bitcoin-config.h do so with the appropriate subfolder prefixed: config/bitcoin-config.h
The header should be included with the appropriate subfolder here as well.

This canonicalization also allows getting rid of a bit of extra configuration in Makefile.am.

5abb93f0ee

danra force-pushed on Aug 31, 2017
danra commented at 6:47 PM on August 31, 2017: contributor

@MarcoFalke @laanwj Done, thanks
laanwj merged this on Sep 5, 2017
laanwj closed this on Sep 5, 2017
laanwj referenced this in commit 3aa60b7ff9 on Sep 5, 2017
PastaPastaPasta referenced this in commit 29227fe689 on Sep 20, 2019
PastaPastaPasta referenced this in commit d0ff791256 on Sep 23, 2019
PastaPastaPasta referenced this in commit f9077a1b6c on Sep 24, 2019
PastaPastaPasta referenced this in commit 34a6986f24 on Nov 19, 2019
PastaPastaPasta referenced this in commit 52e19af9cf on Nov 21, 2019
PastaPastaPasta referenced this in commit 0fa3449f18 on Dec 9, 2019
PastaPastaPasta referenced this in commit 01cda5c168 on Jan 1, 2020
PastaPastaPasta referenced this in commit 16d1ec7834 on Jan 2, 2020
PastaPastaPasta referenced this in commit ac414b9745 on Jan 2, 2020
PastaPastaPasta referenced this in commit c9dbb1325b on Jan 2, 2020
ckti referenced this in commit d973231103 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels