Improve versionbits_computeblockversion test code consistency #11160

pull danra wants to merge 1 commits into bitcoin:master from danra:patch-9 changing 1 files +4 −4

danra commented at 12:12 PM on August 26, 2017: contributor

In this test, nTime is used for all the calls to Mine(), each time being set to the correct time beforehand, except for in the last few calls to Mine() where nStartTime is used directly, even though nTime is still set to nStartTime beforehand. nTime just remains unused for these last few calls to Mine().

Changed the last few calls to Mine() to use nTime instead, improving consistency. This also fixes an unused value static analyzer warning about nTime being set to a value which is never used.
promag commented at 3:55 PM on August 26, 2017: member

PR title longer than the patch :trollface:
danra commented at 9:16 PM on August 26, 2017: contributor

looks like a spurious failure, please rerun
fanquake added the label Tests on Aug 27, 2017
sipa commented at 7:01 PM on August 27, 2017: member

utACK 81d4f3c50c505afe2f8352f8614c6490e3b65699, but can you use a shorter commit title (the first line of the commit message is treated specially, and shouldn't be too long, as it goes into release notes etc).

Improve versionbits_computeblockversion test code consistency

In this test, `nTime` is used for all the calls to `Mine()`, each time being set to the correct time beforehand, except for in the last few calls to `Mine()` where `nStartTime` is used directly, even though `nTime` is still set to `nStartTime` beforehand. `nTime` just remains unused for these last few calls to `Mine()`.

Changed the last few calls to `Mine()` to use `nTime` instead, improving consistency. This also fixes an unused value static analyzer warning about `nTime` being set to a value which is never used.

946638d0a0

danra force-pushed on Aug 27, 2017
danra renamed this:
~~Tests: Improve versionbits_computeblockversion test code consistency and fix…~~
Improve versionbits_computeblockversion test code consistency
on Aug 27, 2017
danra commented at 9:04 PM on August 27, 2017: contributor

@promag @sipa Shortened title :)
MarcoFalke commented at 10:23 PM on August 27, 2017: member

utACK 946638d
MarcoFalke merged this on Aug 27, 2017
MarcoFalke closed this on Aug 27, 2017
MarcoFalke referenced this in commit ede386c219 on Aug 27, 2017
PastaPastaPasta referenced this in commit 86e75dbfb3 on Sep 19, 2019
PastaPastaPasta referenced this in commit 471dd91bbd on Sep 23, 2019
PastaPastaPasta referenced this in commit e72305e659 on Sep 24, 2019
PastaPastaPasta referenced this in commit 1114e7d90d on Nov 19, 2019
PastaPastaPasta referenced this in commit 0cd14bf549 on Nov 21, 2019
PastaPastaPasta referenced this in commit bcc61edb41 on Dec 9, 2019
PastaPastaPasta referenced this in commit 49ce14006a on Jan 1, 2020
PastaPastaPasta referenced this in commit cf2019c98e on Jan 2, 2020
PastaPastaPasta referenced this in commit eb0de04d62 on Jan 2, 2020
ckti referenced this in commit 080cfb6077 on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels