Remove redundant explicitly defined copy ctors #11161

pull danra wants to merge 1 commits into bitcoin:master from danra:fix/redundant-CFeeRate-copy-ctor changing 3 files +0 −8

danra commented at 1:38 PM on August 26, 2017: contributor

CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.

Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ). (Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
promag commented at 4:05 PM on August 26, 2017: member

Remove periods from PR title and commit message.

Otherwise trivial ACK 8a14a86.
danra renamed this:
~~Remove redundant explicitly defined CFeeRate copy ctor.~~
Remove redundant explicitly defined CFeeRate copy ctor
on Aug 26, 2017
danra force-pushed on Aug 26, 2017
danra commented at 4:08 PM on August 26, 2017: contributor

@promag Done
danra renamed this:
~~Remove redundant explicitly defined CFeeRate copy ctor~~
Remove redundant explicitly defined copy ctors
on Aug 26, 2017
promag commented at 6:53 PM on August 26, 2017: member

Please rebase (remove merge commit).
danra force-pushed on Aug 26, 2017
danra commented at 7:03 PM on August 26, 2017: contributor

@promag Done
fanquake added the label Refactoring on Aug 27, 2017
sipa commented at 6:59 PM on August 27, 2017: member

utACK f92b20a85e37b2ce91cc48fa9d7a1f29e353ff13
MarcoFalke commented at 10:26 PM on August 27, 2017: member

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.

No need for two commits on a 8-line-changed patch doing the same thing.

Remove redundant explicitly defined copy ctors

CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.

Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
CFeeRate has an explicitly defined copy ctor which has the same functionality as the implicit default copy ctor which would h
ave been generated otherwise.

b426e24678

danra force-pushed on Aug 27, 2017
danra commented at 10:31 PM on August 27, 2017: contributor

@MarcoFalke Done
laanwj commented at 7:43 AM on August 28, 2017: member

utACK b426e24
laanwj merged this on Aug 28, 2017
laanwj closed this on Aug 28, 2017
laanwj referenced this in commit 745bbdc189 on Aug 28, 2017
PastaPastaPasta referenced this in commit 180868a59a on Sep 19, 2019
PastaPastaPasta referenced this in commit 81c351cace on Sep 23, 2019
PastaPastaPasta referenced this in commit e32e2e237e on Sep 24, 2019
PastaPastaPasta referenced this in commit 9ec52f245f on Nov 19, 2019
PastaPastaPasta referenced this in commit 47badca9ca on Nov 21, 2019
PastaPastaPasta referenced this in commit 8dc9ee3dc5 on Dec 9, 2019
PastaPastaPasta referenced this in commit b1dac9b058 on Jan 1, 2020
PastaPastaPasta referenced this in commit 0ec5204b8f on Jan 2, 2020
PastaPastaPasta referenced this in commit f659cc97ac on Jan 2, 2020
furszy referenced this in commit f6b14ca9ef on Jan 21, 2021
ckti referenced this in commit ca17881c53 on Mar 28, 2021
gades referenced this in commit bc5c16ffb6 on Jun 24, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels