[GUI] Proxies in QSettings storage without a colon cause crashes when options dialog is opened #11209

1. 
   achow101 commented at 2:24 am on September 1, 2017: member

   If addrProxy or addrSeparateProxyTor do not have a colon in the string somewhere in the QSettings storage, then attempting to open the options dialog will cause the entire program to crash.

   I’m not sure if this is really a problem since it is impossible to make those strings not have colons in them from normal operation. In order to replicate this, you must modify what QSettings stores (a conf file in Linux and Registry in Windows).

2. 
   meshcollider commented at 10:41 am on September 1, 2017: contributor

   Easy to fix, but yeah I don’t think its really an issue if it can only be caused through deliberate tampering. Happy to submit a PR if needed and no one else does though
3. fanquake added the label GUI on Sep 1, 2017
4. jonasschnelli added the label Priority Low on Sep 3, 2017
5. laanwj closed this on Oct 9, 2017

   ---

6. laanwj referenced this in commit d473e6ddc5 on Oct 9, 2017
7. PastaPastaPasta referenced this in commit 88197c7414 on Jan 26, 2020
8. ckti referenced this in commit 3216ba5b54 on Mar 28, 2021
9. MarcoFalke locked this on Sep 8, 2021
10. gades referenced this in commit 1c0c9e0aad on Feb 22, 2022

Contributors
achow101 meshcollider

Labels
GUI