Stop test_bitcoin-qt touching ~/.bitcoin #11210

1. 
   meshcollider commented at 11:22 am on September 1, 2017: contributor

   Fixes #11192

   The directory remains unused, but this stops the tests touching ~/.bitcoin at all (namely creating it if it doesn’t exist)

2. Stop test_bitcoin-qt touching ~/.bitcoin dea086f498
3. fanquake added the label Tests on Sep 1, 2017
4. 
   meshcollider commented at 11:38 am on September 1, 2017: contributor

   Travis failure is in an unrelated test, please rerun :)
5. 
   jonasschnelli commented at 5:19 pm on September 3, 2017: contributor

   utACK dea086f498097d19a2c9acbfc753c9c2d68dbb03
6. 
   cdecker commented at 6:55 pm on September 3, 2017: contributor

   utACK dea086f498097d19a2c9acbfc753c9c2d68dbb03
7. in src/qt/test/test_main.cpp:56 in dea086f498

   52@@ -53,6 +53,10 @@ int main(int argc, char *argv[])
   53     SetupNetworking();
   54     SelectParams(CBaseChainParams::MAIN);
   55     noui_connect();
   56+    ClearDatadirCache();
   

   ---

   ---

   

   sipa commented at 9:09 pm on September 3, 2017:

   Any reason to only do this for Qt?

   ---

   

   laanwj commented at 4:07 pm on September 5, 2017:

   We already do it on src/test/test_bitcoin.cpp
8. 
   laanwj commented at 4:09 pm on September 5, 2017: member

   Tested ACK dea086f49, thanks!
9. laanwj merged this on Sep 6, 2017
10. laanwj closed this on Sep 6, 2017

    ---

11. laanwj referenced this in commit 5368614aa1 on Sep 6, 2017
12. 
    laanwj commented at 5:21 pm on September 6, 2017: member

    @MarcoFalke mentioned needing a test for this on travis (that the tests don’t touch ~/.bitcoin) but this can be done in a separate PR
13. 
    MarcoFalke commented at 7:35 pm on September 6, 2017: member

    Making sure that ~/.bitcoin istn’t touched implies that something creates it first. Not sure if we want that in our .travis.yml.
14. meshcollider deleted the branch on Sep 7, 2017
15. MarcoFalke referenced this in commit f3f7891776 on Oct 3, 2017
16. 
    luke-jr commented at 9:05 am on November 10, 2017: member

    @MarcoFalke Eh, we can just add a check that ~/.bitcoin still doesn’t exist at the end?
17. 
    MarcoFalke commented at 12:24 pm on November 10, 2017: member

    Iirc we did that and it failed occasionally. This is on my list of things to take a look at …

    On Nov 10, 2017 04:06, “Luke Dashjr” notifications@github.com wrote:

    @MarcoFalke https://github.com/marcofalke Eh, we can just add a check that ~/.bitcoin still doesn’t exist at the end?

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/11210#issuecomment-343417188, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv7gKKJCFcDv-SytUAyUvBZFKuA32ks5s1BIcgaJpZM4PKBvu .

18. PastaPastaPasta referenced this in commit 3f58854430 on Sep 20, 2019
19. PastaPastaPasta referenced this in commit cf661c76e3 on Sep 23, 2019
20. PastaPastaPasta referenced this in commit 12978d4d76 on Sep 23, 2019
21. PastaPastaPasta referenced this in commit e9bb574960 on Sep 24, 2019
22. codablock referenced this in commit a2e8cb4f45 on Sep 24, 2019
23. barrystyle referenced this in commit 619cc569f4 on Jan 22, 2020
24. DrahtBot locked this on Sep 8, 2021

Contributors
meshcollider jonasschnelli cdecker sipa laanwj MarcoFalke luke-jr

Labels
Tests